<html><head></head><body dir="auto" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div class="ApplePlainTextBody"><br><blockquote type="cite">On Jan 7, 2018, at 1:36 PM, Matthew R. Ochs <mrochs@linux.vnet.ibm.com> wrote:<br><br>On Thu, Jan 04, 2018 at 05:33:48PM +1100, Andrew Donnellan wrote:<br><blockquote type="cite">On 04/01/18 09:54, Uma Krishnan wrote:<br><blockquote type="cite">In the event of a command failure, cxlflash returns the failure to the<br>upper layers to process. After processing the error, when the command is<br>queued again, the private command structure will not be zeroed and the<br>ioasc could be stale. Per the SISLite specification, the AFU only sets the<br>ioasc in the presence of a failure. Thus, even though the original command<br>succeeds the second time, the command is considered a failure due to stale<br>ioasc. This cycle repeats indefinitely and can cause a hang or IO failure.<br><br>To fix the issue, clear the ioasc before queuing any command.<br><br>Fixes: 479ad8e9d48c ("scsi: cxlflash: Remove zeroing of private command<br>data")<br>Signed-off-by: Uma Krishnan <ukrishn@linux.vnet.ibm.com><br></blockquote><br>Should this go to stable?<br></blockquote><br>Not a bad idea.<br><br></blockquote><br><br>I will forward the patch to stable once the patch is in next/master. <br>Unless there is a need to send a V2. Thanks for pointing out Andrew !!</div></body></html>