<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Dec 20, 2017 at 3:40 AM, Arnaud Mouiche <span dir="ltr"><<a href="mailto:arnaud.mouiche@invoxia.com" target="_blank">arnaud.mouiche@invoxia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="m_1402007462445227494gmail-HOEnZb"><div class="m_1402007462445227494gmail-h5"><br>
<br>
On 19/12/2017 01:25, Caleb Crome wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
On Mon, Dec 18, 2017 at 3:02 PM, Nicolin Chen <<a href="mailto:nicoleotsuka@gmail.com" target="_blank">nicoleotsuka@gmail.com</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
On Mon, Dec 18, 2017 at 02:19:08PM -0800, Caleb Crome wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Acked-by: Timur Tabi <<a href="mailto:timur@tabi.org" target="_blank">timur@tabi.org</a>><br>
</blockquote></blockquote>
--- To Mark ---<br>
<br>
Mark, can you still take these changes first? Since this failed<br>
test that Caleb reported here is already existing on the top of<br>
the mainline tree, I would like to treat this mail as a separate<br>
bug report and fix it with a separate patch.<br>
<br>
Besides, this series of changes don't change any function flow.<br>
<br>
Thank you<br>
<br>
</blockquote>
Sorry! I should have created a separate thread for this subject. My<br>
comments have *nothing* to do with this patch set, except they are<br>
about the same source files.<br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
--- To Caleb ---<br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
I'm re-setting up my loopback test to try to verify these most recent changes.<br>
</blockquote>
I really appreciate your verification and help.<br>
</blockquote>
Of course! I have this wandboard permanently set up for this<br>
verification test, so that I can easily repeat whenever I touch our<br>
kernel.<br>
<br>
It's a dead-simple hardware mod just to connect TX to RX.<br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
warn: 11a0 11a1 1160 11a3 11a4 11a5 11a6 11a7<br>
warn: Valid frame after 1 invalid frames<br>
warn: 11c0 11c1 11c2 11c3 11c4 11c5 11c6 11c7<br>
warn: first invalid frame while expecting frame 0x00a0<br>
warn: 13e7 1400 1401 1402 1403 1404 1405 1404<br>
warn: 1407 1420 1421 1422 1423 1424 1425 1426<br>
warn: 1427 1440 1441 1442 1443 1444 1445 1484<br>
warn: 1447 1460 1461 1462 1463 1464 1465 1466<br>
<br>
Those last 4 lines are the channel slips -- the least significant<br>
nibble should be the channel number: i.e. should go 0, 1, 2, 3, 4, 5,<br>
6, 7.<br>
<br>
Ugh, so it's basically quite broken again -- before these patches.<br>
</blockquote>
I remember Arnaud reviewed one of my changes back to September.<br>
So I suppose the test should be fine at that time -- so a change<br>
being merged recently might have impacted the test result.<br>
</blockquote>
<br>
It's certainly possible that I'm doing something wrong again -- it<br>
wouldn't be the first time :-)<br>
</blockquote>
<br></div></div>
Hi All,<br>
<br>
Sorry but I will be busy until mid January, I could help testing and fixing broken multi channel after.<br>
Anyway, I don't see specific issues with Nicolin patches.<br>
We can take time to fix what was broken before this patch set... after.<span class="m_1402007462445227494gmail-HOEnZb"><font color="#888888"><br>
<br>
Arnaud</font></span><div class="m_1402007462445227494gmail-HOEnZb"><div class="m_1402007462445227494gmail-h5"><br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
I guess I need to go backwards in time and see what rev re-broke it.<br>
I don't really have time to dig too deep on this again.<br>
<br>
I'd be happy to provide the hardware to anybody that can diagnose and<br>
debug this more quickly than I can. I'm very inefficient at kernel<br>
drivers I think. My day job is acoustical and electrical<br>
engineering.<br>
<br>
Here's what the hardware looks like for anybody that's interested.<br>
Just a single wire loopback on the wandboard header.<br>
</blockquote>
I would definitely like to take the hardware to debug it as long<br>
as you are willing to provide me. Can you send me a private mail<br>
to discuss about it?<br>
</blockquote>
Absolutely.<br>
-Caleb<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Thanks<br>
Nicolin<br>
</blockquote></blockquote>
<br></div></div></blockquote><div><br></div><div>Okay, operator error on my part. There was an old clock setting in my ssi3 dtsi file that (falsely) modified the ssi baud clock frequency. Nicolin's patch </div><div><br></div><div> ASoC: fsl_ssi: Caculate bit clock rate using slot number and width</div><div><br></div><div>now properly computes the master clock, and the old dtsi settings that were necessary to fake things into the right speed are now obsolete.</div><div><br></div><div>So... basically, everything is back to working properly. it wasn't broken at all -- just my oversight on a ssi clock setting in the dtb.</div><div><br></div><div>-Caleb</div><div><br></div><div><br></div></div><br></div></div>