<div class="socmaildefaultfont" dir="ltr" style="font-family:Arial;font-size:10.5pt" ><div dir="ltr" style="font-family:Arial;font-size:10.5pt" ><div dir="ltr" >Hey guys - our system test team opened a defect on this, since Ubuntu (as it stands) is broken now with CAPI Flash cards.
<div> </div>
<div><div>Dion opened bug <font face="Default Sans Serif,Verdana,Arial,Helvetica,sans-serif" size="2" ><a href="https://bugzilla.linux.ibm.com/show_bug.cgi?id=140054" >https://bugzilla.linux.ibm.com/show_bug.cgi?id=140054</a> . </font></div>
<div> </div>
<div><font face="Default Sans Serif,Verdana,Arial,Helvetica,sans-serif" size="2" >So - this is important. You need to tested to confirm that this is in-fact the root cause of Dion's bug, fix it, verify that a Surelock AFU boots correctly (and cxlflash loads), and then push a patch in 16.04</font> in time for the release (in a few weeks).</div>
<div> </div>
<div>~ Mike</div>
<div>
<div><br><b><font face="Arial" color="#888888" size="3" >Michael C. Hollinger</font></b><br><tt><b><font face="" color="#8F8F8F" size="3" >和宇喆</font></b></tt><br><font face="Arial" size="2" >Master Inventor</font><br><font face="Arial" size="2" >Power Open Source Solutions</font><br><font face="Arial" size="2" >IBM Systems<br>Austin, TX Development Lab</font>
<table border="0" cellpadding="0" cellspacing="0" > <tbody> <tr valign="top" > <td colspan="3" valign="middle" width="680" > <hr align="left" size="2" width="100%" ></td> </tr> <tr valign="top" > <td width="100" ><img src="cid:145997438113021" height="100" width="100" ></td> <td width="355" ><b><font face="Arial" color="#466BB0" size="1" >Phone:</font></b><font face="Arial" color="#5F5F5F" size="1" > 1-512-286-6688</font><font face="Arial" color="#466BB0" size="1" > | </font><b><font face="Arial" color="#466BB0" size="1" >Tie-Line:</font></b><font face="Arial" color="#5F5F5F" size="1" > 363-6688</font><font face="Arial" color="#466BB0" size="1" > | </font><b><font face="Arial" color="#466BB0" size="1" >Mobile:</font></b><font face="Arial" color="#5F5F5F" size="1" > 1-512-850-6153</font><br> <b><font face="Arial" color="#466BB0" size="1" >E-mail:</font></b><font face="Arial" color="#5F5F5F" size="1" > </font><a href="mailto:mchollin@us.ibm.com" target="_blank" ><u><font face="Arial" color="#5F5F5F" size="1" >mchollin@us.ibm.com</font></u></a><br> <b><font face="Arial" color="#466BB0" size="1" >Chat:</font></b><img alt="Sametime: " src="cid:145997438113022" height="16" width="16" ><font face="Arial" color="#5F5F5F" size="1" > mchollin@us.ibm.com </font><br> <b><font face="Arial" color="#466BB0" size="1" >Find me on:</font></b><font face="Arial" color="#5F5F5F" size="1" > </font><a href="http://www.linkedin.com/in/mikehollinger" target="_blank" ><img alt="LinkedIn: http://www.linkedin.com/in/mikehollinger" src="cid:145997438113023" height="16" border="0" width="16" ></a><font face="Arial" color="#5F5F5F" size="1" > </font><a href="http://www.twitter.com/mike_hollinger" target="_blank" ><img alt="Twitter: http://www.twitter.com/mike_hollinger" src="cid:145997438113024" height="16" border="0" width="16" ></a><font face="Arial" color="#5F5F5F" size="1" > </font><a href="https://plus.google.com/100310751329925639140/" target="_blank" ><img alt="GooglePlus: https://plus.google.com/100310751329925639140/" src="cid:145997438113025" height="16" border="0" width="16" ></a><font face="Arial" color="#5F5F5F" size="1" > </font><b><font face="Arial" color="#466BB0" size="1" >and within IBM on:</font></b><font face="Arial" color="#5F5F5F" size="1" > </font><a href="http://w3.ibm.com/connections/profiles/html/profileView.do?email=mchollin@us.ibm.com&lang=en" target="_blank" ><img alt="IBM Connections: http://w3.ibm.com/connections/profiles/html/profileView.do?email=mchollin@us.ibm.com&lang=en" src="cid:145997438113026" height="16" border="0" width="16" ></a><font face="Arial" color="#5F5F5F" size="1" > </font></td> <td width="225" > <div align="right" ><img alt="IBM" src="cid:145997438113027" height="30" width="83" ><br> <br> <font face="Arial" color="#5F5F5F" size="1" >11400 Burnet Road</font><br> <font face="Arial" color="#5F5F5F" size="1" >Austin, TX 78758</font></div> </td> </tr> </tbody></table>
<div> </div>
<div> </div>
<blockquote data-history-content-modified="1" style="border-left:solid #aaaaaa 2px; margin-left:5px; padding-left:5px; direction:ltr; margin-right:0px" >----- Original message -----<br>From: "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com><br>To: Ian Munsie <imunsie@au1.ibm.com><br>Cc: mikey <mikey@neuling.org>, Michael C Hollinger/Austin/IBM@IBMUS, Frederic Barrat <frederic.barrat@fr.ibm.com>, linux-pci <linux-pci@vger.kernel.org>, "Matthew R. Ochs" <mrochs@linux.vnet.ibm.com>, gwshan <gwshan@linux.vnet.ibm.com>, Manoj Kumar/Austin/IBM@IBMUS, paulus <paulus@samba.org>, "andrew.donnellan" <andrew.donnellan@au1.ibm.com>, bhelgaas <bhelgaas@google.com>, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, Michael Ellerman <mpe@ellerman.id.au><br>Subject: Re: [PATCH v4] powerpc/pci: Assign fixed PHB number based on device-tree properties<br>Date: Wed, Apr 6, 2016 4:51 PM<br>
<div><font face="Default Monospace,Courier New,Courier,monospace" size="2" >On 04/06/2016 04:38 PM, Ian Munsie wrote:<br>>> + /* try fixed PHB numbering first, by checking archs and reading<br>>> + * the respective device-tree property. */<br>>> + if (machine_is(pseries)) {<br>>> + regs = of_get_property(dn, "reg", NULL);<br>>> + if (regs)<br>>> + return (int)(be32_to_cpu(regs[1]) & 0xFFFF);<br>>> + } else if (machine_is(powernv)) {<br>>> + prop64 = of_get_property(dn, "ibm,opal-phbid", NULL);<br>>> + if (prop64)<br>>> + return (int)(be64_to_cpup(prop64) & 0xFFFF);<br>>> + }<br>><br>> I think these cases should still set the bit in phb_bitmap, otherwise a<br>> virtual PHB (e.g. as used in cxl/cxlflash) will be assigned PHB 0, and<br>> since that is already taken it will fail - we're already seeing a<br>> failure in Ubuntu Xenial since Canonical picked this patch up already<br>> (though have not confirmed that this is definitely the cause yet).<br>><br>> There might also be some interesting races to think about here if a<br>> virtual PHB grabs a PHB number before the real one gets a chance.<br><br>This is a very interesting case I didn't think before. Thanks for<br>pointing this Ian.<br><br>We can, as you suggested, set the bitmap in any case to avoid conflicts<br>with virtual PHBs.<br><br>And in the case a virtual PHB grabs the bitmap before, we just need to<br>add Michael's suggested check and fallback to bitmap PHB numbering in<br>this case.<br><br>Do you think this is enough to avoid issues with cxl'a virtual PHBs?<br><br>Thanks,<br><br><br>Guilherme</font></div></blockquote></div></div></div></div></div></div>
<BR>