<meta http-equiv="Content-Type" content="text/html charset=windows-1252">One other thing.<div><br></div><div>The way to present all the people who submitted, such that each one got some amount of exposure, was a dynamic thing that just occurred to me as we were setting up.</div><div><br></div><div>Sort of like you first starting to select the judging panels, by ‘guessing’ a number… which didn’t work very well, but then counting out groups did. (even if there were groups that had some extras because the group was an odd number…).</div><div><br></div><div>Next time, we will have this in mind and it will be very straightforward… 1,2,3… for both how to select the panels, and how to present the submissions.</div><div><br></div><div>Love,</div><div>John.</div><div><br></div><div><br><div><div>On Sep 4, 2015, at 3:46 PM, Guilherme G. Piccoli [via linuxppc] <<a href="/user/SendEmail.jtp?type=node&node=98195&i=0" target="_top" rel="nofollow" link="external">[hidden email]</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote style='border-left:2px solid #CCCCCC;padding:0 1em' type="cite">
Hello Bjorn,
<br><br>> of_create_pci_dev() already has a lot of code that duplicates
<br>> pci_setup_device(), and it's a shame to add more. There's also a sparc
<br>> version of of_create_pci_dev() that presumably has the same problem you're
<br>> fixing for powerpc.
<br><br>Thanks for the information!
<br><div class="shrinkable-quote"><div class='shrinkable-quote'><br>> Michael originally called pci_msi_setup_pci_dev() from
<br>> pci_init_capabilities() [1]. A subsequent patch moved the call
<br>> to pci_setup_device() [2] because an early quirk (called from
<br>> pci_setup_device()) used pci_msi_off(), which depended on
<br>> pci_msi_setup_pci_dev().
<br>>
<br>> But we later removed pci_msi_off() completely, so I think we probably
<br>> *could* call pci_msi_setup_pci_dev() from pci_init_capabilities().
<br>>
<br>> That would be much nicer because it makes more sense there, and it
<br>> would do the right thing for powerpc and sparc because they both
<br>> already use that path.
<br>>
<br>> Can you look into moving the call?
</div></div>I might have misunderstood something here (sorry if it's the case), but
<br>moving the call to pci_init_capabilities() has the same practical
<br>implications than reverting my 2 commmits [1] [2] and Michael Tsirkin's
<br>commit [3], except when CONFIG_PCI_MSI is not set - in this case, moving
<br>the call would initialize MSI capabilities anyway, since
<br>pci_init_capabilities() executes even if CONFIG_PCI_MSI isn't set.
<br><br>My question is: is necessary to initialize MSI capabilities even with
<br>CONFIG_PCI_MSI not set? In negative case, would be "cleaner" revert the
<br>3 commits, right?
<br><br>On the other hand, if it's necessary to initialize MSI capabilities on
<br>devices anyway, we can change the call place.
<br><br>Let me know your opinion, and I'm sorry if I misunderstood something here.
<br><br>Cheers,
<br><br><br>Guilherme Piccoli
<br><br><br><br>[1] commit 22b6839b914b ("PCI: Make pci_msi_setup_pci_dev() non-static
<br>for use by arch code")
<br><br>[2] commit 4d9aac397a5d ("powerpc/PCI: Disable MSI/MSI-X interrupts at
<br>PCI probe time in OF case")
<br><br>[3] commit 1851617cd2da ("PCI/MSI: Disable MSI at enumeration even if
<br>kernel doesn't support MSI")
<br><br>_______________________________________________
<br>Linuxppc-dev mailing list
<br><a href="x-msg://17/user/SendEmail.jtp?type=node&node=98194&i=0" target="_top" rel="nofollow" link="external">[hidden email]</a>
<br><a href="https://lists.ozlabs.org/listinfo/linuxppc-dev" target="_top" rel="nofollow" link="external">https://lists.ozlabs.org/listinfo/linuxppc-dev</a>
<br>
<br>
<hr noshade="noshade" size="1">
<div style="color:#444; font: 12px tahoma,geneva,helvetica,arial,sans-serif;">
<div style="font-weight:bold">If you reply to this email, your message will be added to the discussion below:</div>
<a href="http://linuxppc.10917.n7.nabble.com/PATCH-0-2-Disable-MSI-MSI-X-interrupts-manually-at-PCI-probe-time-in-PowerPC-architecture-tp97680p98194.html" target="_top" rel="nofollow" link="external">http://linuxppc.10917.n7.nabble.com/PATCH-0-2-Disable-MSI-MSI-X-interrupts-manually-at-PCI-probe-time-in-PowerPC-architecture-tp97680p98194.html</a>
</div>
<div style="color:#666; font: 11px tahoma,geneva,helvetica,arial,sans-serif;margin-top:.4em;line-height:1.5em">
To start a new topic under linuxppc-dev, email <a href="/user/SendEmail.jtp?type=node&node=98195&i=1" target="_top" rel="nofollow" link="external">[hidden email]</a> <br>
To unsubscribe from linuxppc, <a href="" target="_top" rel="nofollow" link="external">click here</a>.<br>
<a href="http://linuxppc.10917.n7.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml" rel="nofollow" style="font:9px serif" target="_top" link="external">NAML</a>
</div></blockquote></div><br></div>
<br/><hr align="left" width="300" />
View this message in context: <a href="http://linuxppc.10917.n7.nabble.com/PATCH-0-2-Disable-MSI-MSI-X-interrupts-manually-at-PCI-probe-time-in-PowerPC-architecture-tp97680p98195.html">Re: [PATCH v2 2/2] powerpc/PCI: Disable MSI/MSI-X interrupts at PCI probe time in OF case</a><br/>
Sent from the <a href="http://linuxppc.10917.n7.nabble.com/linuxppc-dev-f3.html">linuxppc-dev mailing list archive</a> at Nabble.com.<br/>