<div dir="ltr"><div id=":38l" tabindex="-1" class="" style="font-size:medium"><div id=":383" class="" tabindex="0"><img class="" src="https://ssl.gstatic.com/ui/v1/icons/mail/images/cleardot.gif"></div></div><div id=":38x" class="" style="font-size:12.8000001907349px"><div id=":38y" class="" style="overflow:hidden"><div class=""><div class="adm"></div><div class="im">On 30 March 2015 at 16:46, Suman Tripathi <<a href="mailto:stripathi@apm.com">stripathi@apm.com</a>> wrote:<br>> This patch adds some quirks support to be read from fdt.<br>><br>> Signed-off-by: Suman Tripathi <<a href="mailto:stripathi@apm.com">stripathi@apm.com</a>><br>> ---<br>>  drivers/mmc/host/sdhci-pltfm.c | 15 +++++++++++++++<br>>  1 file changed, 15 insertions(+)<br>><br>> diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c<br>> index bef250e..9f6a4b9 100644<br>> --- a/drivers/mmc/host/sdhci-pltfm.c<br>> +++ b/drivers/mmc/host/sdhci-pltfm.c<br>> @@ -85,6 +85,21 @@ void sdhci_get_of_property(struct platform_device *pdev)<br>><br>>                 if (of_get_property(np, "broken-cd", NULL))<br>>                         host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION;<br>> +<br>> +               if (of_get_property(np, "delay-after-power", NULL))<br>> +                       host->quirks |= SDHCI_QUIRK_DELAY_AFTER_POWER;<br>> +<br>> +               if (of_get_property(np, "no-hispd", NULL))<br>> +                       host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT;<br>> +<br>> +               if (of_get_property(np, "broken-adma", NULL))<br>> +                       host->quirks |= SDHCI_QUIRK_BROKEN_ADMA;<br>> +<br>> +               if (of_get_property(np, "broken-dma", NULL))<br>> +                       host->quirks |= SDHCI_QUIRK_BROKEN_DMA;<br>> +<br>> +               if (of_get_property(np, "no-cmd23", NULL))<br>> +                       host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23;<br><br></div></div>Can't at least some of these be distinguished from what sdhci variant<br>that is being used? Instead of having them in DT...</div><div id=":38y" class="" style="overflow:hidden"><br></div><div id=":38y" class="" style="overflow:hidden">We are using arasan controller in our SOC. So reusing a the existing sdhci-of-arasan driver. Due to H/W issues we require this quirks. So for us only option left to pass the info is DTS or ACPI table. <br><br>Kind regards<br>Uffe<div class=""><div id=":382" class="" tabindex="0"><img class="" src="https://ssl.gstatic.com/ui/v1/icons/mail/images/cleardot.gif"></div></div></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Apr 8, 2015 at 3:10 PM, Ulf Hansson <span dir="ltr"><<a href="mailto:ulf.hansson@linaro.org" target="_blank">ulf.hansson@linaro.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On 30 March 2015 at 16:46, Suman Tripathi <<a href="mailto:stripathi@apm.com">stripathi@apm.com</a>> wrote:<br>
> This patch adds some quirks support to be read from fdt.<br>
><br>
> Signed-off-by: Suman Tripathi <<a href="mailto:stripathi@apm.com">stripathi@apm.com</a>><br>
> ---<br>
>  drivers/mmc/host/sdhci-pltfm.c | 15 +++++++++++++++<br>
>  1 file changed, 15 insertions(+)<br>
><br>
> diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c<br>
> index bef250e..9f6a4b9 100644<br>
> --- a/drivers/mmc/host/sdhci-pltfm.c<br>
> +++ b/drivers/mmc/host/sdhci-pltfm.c<br>
> @@ -85,6 +85,21 @@ void sdhci_get_of_property(struct platform_device *pdev)<br>
><br>
>                 if (of_get_property(np, "broken-cd", NULL))<br>
>                         host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION;<br>
> +<br>
> +               if (of_get_property(np, "delay-after-power", NULL))<br>
> +                       host->quirks |= SDHCI_QUIRK_DELAY_AFTER_POWER;<br>
> +<br>
> +               if (of_get_property(np, "no-hispd", NULL))<br>
> +                       host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT;<br>
> +<br>
> +               if (of_get_property(np, "broken-adma", NULL))<br>
> +                       host->quirks |= SDHCI_QUIRK_BROKEN_ADMA;<br>
> +<br>
> +               if (of_get_property(np, "broken-dma", NULL))<br>
> +                       host->quirks |= SDHCI_QUIRK_BROKEN_DMA;<br>
> +<br>
> +               if (of_get_property(np, "no-cmd23", NULL))<br>
> +                       host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23;<br>
<br>
</div></div>Can't at least some of these be distinguished from what sdhci variant<br>
that is being used? Instead of having them in DT...<br>
<br>
Kind regards<br>
Uffe<br>
<div class="HOEnZb"><div class="h5"><br>
><br>
>                 if (of_get_property(np, "no-1-8-v", NULL))<br>
>                         host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V;<br>
> --<br>
> 1.8.2.1<br>
><br>
</div></div><span class="HOEnZb"><font color="#888888">> --<br>
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in<br>
> the body of a message to <a href="mailto:majordomo@vger.kernel.org">majordomo@vger.kernel.org</a><br>
> More majordomo info at  <a href="http://vger.kernel.org/majordomo-info.html" target="_blank">http://vger.kernel.org/majordomo-info.html</a><br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div>Thanks,</div><div>with regards,</div>Suman Tripathi</div></div>
</div>