<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 01/14/2015 10:01 AM, Michael
Ellerman wrote:<br>
</div>
<blockquote cite="mid:1421209860.10748.10.camel@ellerman.id.au"
type="cite">
<pre wrap="">On Wed, 2014-12-24 at 17:28 +0530, Hari Bathini wrote:
</pre>
<blockquote type="cite">
<pre wrap="">With minor checks, we can move most of the code for nvram
under pseries to a common place to be re-used by other
powerpc platforms like powernv. This patch moves such
common code to arch/powerpc/kernel/nvram_64.c file.
</pre>
</blockquote>
<pre wrap="">As I said in my reply to the previous version:
... you need to keep in mind that it is very common for us to build kernels
with both POWERNV=y and PSERIES=y.
So you need to make sure you're only using CONFIG_PPC_PSERIES to protect things
that are optional on pseries. Not things that we *shouldn't* be doing on
powernv.
</pre>
</blockquote>
<br>
we could as well do away with the PPC_PSERIES flag in a couple of
places in<br>
arch/powerpc/kernel/nvram_64.c, but doing that will unnecessarily
add<br>
few extra variables for !PPC_PSERIES case. <br>
<br>
<blockquote cite="mid:1421209860.10748.10.camel@ellerman.id.au"
type="cite">
<pre wrap="">
Please explain in your commit message how you have dealt with that.
</pre>
</blockquote>
<br>
Sure. Will update the changelog<br>
<br>
<blockquote cite="mid:1421209860.10748.10.camel@ellerman.id.au"
type="cite">
<pre wrap="">
Also, you broke the build for every config that doesn't have
CONFIG_PPC_PSERIES, all 95 of them. This is pasemi_defconfig for example:
</pre>
</blockquote>
<br>
My bad!<font face="sans-serif"> clobbering_unread_rtas_event should
have been static inline</font><br>
while defining under !PPC_PSERIES<br>
<br>
Thanks<br>
Hari<br>
<br>
<blockquote cite="mid:1421209860.10748.10.camel@ellerman.id.au"
type="cite">
<pre wrap=""> LD arch/powerpc/mm/built-in.o
arch/powerpc/mm/init_64.o: In function `clobbering_unread_rtas_event':
init_64.c:(.opd+0x48): multiple definition of `clobbering_unread_rtas_event'
arch/powerpc/mm/mem.o:mem.c:(.opd+0x90): first defined here
arch/powerpc/mm/init_64.o: In function `.clobbering_unread_rtas_event':
init_64.c:(.text+0x80): multiple definition of `.clobbering_unread_rtas_event'
arch/powerpc/mm/mem.o:mem.c:(.text+0x2c0): first defined here
CC arch/powerpc/kernel/udbg.o
/home/kisskb/slave/src/scripts/Makefile.build:336: recipe for target 'arch/powerpc/mm/built-in.o' failed
make[2]: *** [arch/powerpc/mm/built-in.o] Error 1
/home/kisskb/slave/src/Makefile:938: recipe for target 'arch/powerpc/mm' failed
make[1]: *** [arch/powerpc/mm] Error 2
make[1]: *** Waiting for unfinished jobs....
cheers
</pre>
</blockquote>
<br>
</body>
</html>