<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 07/25/2014 04:58 PM, Nicolin Chen
wrote:<br>
</div>
<blockquote cite="mid:20140725112807.GA29852@MrMyself" type="cite">
<pre wrap="">Hi Varka,
On Fri, Jul 25, 2014 at 05:04:11PM +0530, Varka Bhadram wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On 07/25/2014 02:16 PM, Nicolin Chen wrote:
</pre>
<blockquote type="cite">
<pre wrap="">The Asynchronous Sample Rate Converter (ASRC) converts the sampling rate of a
signal associated with an input clock into a signal associated with a different
output clock. The driver currently works as a Front End of DPCM with other Back
Ends DAI links such as ESAI<->CS42888 and SSI<->WM8962 and SAI. It converts the
original sample rate to a common rate supported by Back Ends for playback while
converts the common rate of Back Ends to a desired rate for capture. It has 3
pairs to support three different substreams within totally 10 channels.
Signed-off-by: Nicolin Chen <a class="moz-txt-link-rfc2396E" href="mailto:nicoleotsuka@gmail.com"><nicoleotsuka@gmail.com></a>
---
.../devicetree/bindings/sound/fsl,asrc.txt | 60 ++
sound/soc/fsl/Kconfig | 9 +
sound/soc/fsl/Makefile | 2 +
sound/soc/fsl/fsl_asrc.c | 992 +++++++++++++++++++++
sound/soc/fsl/fsl_asrc.h | 461 ++++++++++
sound/soc/fsl/fsl_asrc_dma.c | 386 ++++++++
6 files changed, 1910 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/fsl,asrc.txt
create mode 100644 sound/soc/fsl/fsl_asrc.c
create mode 100644 sound/soc/fsl/fsl_asrc.h
create mode 100644 sound/soc/fsl/fsl_asrc_dma.c
</pre>
</blockquote>
<pre wrap="">check patch warnings on this patch...
</pre>
</blockquote>
<pre wrap="">
[...]
./scripts/checkpatch.pl --max-line-length=128 0002-ASoC-fsl_a....patch
total: 0 errors, 0 warnings, 1928 lines checked
0002-ASoC....patch has no obvious style problems and is ready for submission
[...]
I think there's no need to be so strict by wrapping all lines inside
80 characters, especially for those that will be less readable if being
wrapped and for those in header file.
</pre>
</blockquote>
<pre>Ohhh .. If this is the case, patch addressed all of comments... Thanks..
<span class="st"><em>Reviewed-by: Varka Bhadram <a class="moz-txt-link-rfc2396E" href="mailto:varkabhadram@gmail.com"><varkabhadram@gmail.com></a></em></span>
</pre>
<pre class="moz-signature" cols="72">--
Regards,
Varka Bhadram.</pre>
</body>
</html>