<div dir="ltr"><br><div class="gmail_extra">Hi Nico,</div><div class="gmail_extra"><br></div><div class="gmail_extra"><div class="gmail_quote"><br></div><div class="gmail_quote">On 6 February 2014 14:16, Nicolas Pitre <span dir="ltr"><<a href="mailto:nicolas.pitre@linaro.org" target="_blank">nicolas.pitre@linaro.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">The core idle loop now takes care of it.<br>
<br>
Signed-off-by: Nicolas Pitre <<a href="mailto:nico@linaro.org">nico@linaro.org</a>><br>
---<br>
arch/powerpc/platforms/powernv/setup.c | 13 +------------<br>
1 file changed, 1 insertion(+), 12 deletions(-)<br>
<br>
diff --git a/arch/powerpc/platforms/powernv/setup.c b/arch/powerpc/platforms/powernv/setup.c<br>
index 21166f65c9..a932feb290 100644<br>
--- a/arch/powerpc/platforms/powernv/setup.c<br>
+++ b/arch/powerpc/platforms/powernv/setup.c<br>
@@ -26,7 +26,6 @@<br>
#include <linux/of_fdt.h><br>
#include <linux/interrupt.h><br>
#include <linux/bug.h><br>
-#include <linux/cpuidle.h><br>
<br>
#include <asm/machdep.h><br>
#include <asm/firmware.h><br>
@@ -217,16 +216,6 @@ static int __init pnv_probe(void)<br>
return 1;<br>
}<br>
<br>
-void powernv_idle(void)<br>
-{<br>
- /* Hook to cpuidle framework if available, else<br>
- * call on default platform idle code<br>
- */<br>
- if (cpuidle_idle_call()) {<br>
- power7_idle();<br>
- }<br></blockquote><div><br></div><div>The cpuidle_idle_call is called from arch_cpu_idle in arch/powerpc/kernel/idle.c between a ppc64_runlatch_off|on section.</div><div>Shouldn't the cpuidle-powernv driver call these functions when entering idle ?</div>
<div><br></div><div> -- Daniel </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
-}<br>
-<br>
define_machine(powernv) {<br>
.name = "PowerNV",<br>
.probe = pnv_probe,<br>
@@ -236,7 +225,7 @@ define_machine(powernv) {<br>
.show_cpuinfo = pnv_show_cpuinfo,<br>
.progress = pnv_progress,<br>
.machine_shutdown = pnv_shutdown,<br>
- .power_save = powernv_idle,<br>
+ .power_save = power7_idle,<br>
.calibrate_decr = generic_calibrate_decr,<br>
#ifdef CONFIG_KEXEC<br>
.kexec_cpu_down = pnv_kexec_cpu_down,<br>
<span class=""><font color="#888888">--<br>
1.8.4.108.g55ea5f6<br>
<br>
</font></span></blockquote></div><br></div></div>