<br><div class="gmail_quote">On Tue, Nov 22, 2011 at 5:00 PM, Josh Boyer <span dir="ltr"><<a href="mailto:jwboyer@gmail.com">jwboyer@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On Tue, Nov 22, 2011 at 2:11 AM, Tanmay Inamdar <<a href="mailto:tinamdar@apm.com">tinamdar@apm.com</a>> wrote:<br>
> Fixing interrupt mapping of EMAC for canyonlands<br>
><br>
> Signed-off-by: Tanmay Inamdar <<a href="mailto:tinamdar@apm.com">tinamdar@apm.com</a>><br>
<br>
</div>As far as I can tell, your changes aren't really changing anything<br>
just making it a bit clearer, correct? If so, do you mind if I change<br>
the commit log to "clear up" instead of fix?<br></blockquote><div><br>Actually Rob Herring's commit (<a href="http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=dc9372808412edbc653a675a526c2ee6c0c14a91">http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=dc9372808412edbc653a675a526c2ee6c0c14a91</a>) breaks the interrupt mapping in EMAC driver.<br>
I am trying to fix this issue by mapping interrupts in different way.<br><br>If you think "clear up" is fine, then please go ahead.<br><br>Thanks,<br>Tanmay<br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
josh<br>
<div><div></div><div class="h5"><br>
> ---<br>
> arch/powerpc/boot/dts/canyonlands.dts | 16 ++++++----------<br>
> 1 files changed, 6 insertions(+), 10 deletions(-)<br>
><br>
> diff --git a/arch/powerpc/boot/dts/canyonlands.dts b/arch/powerpc/boot/dts/canyonlands.dts<br>
> index 3dc75de..c76bbcd 100644<br>
> --- a/arch/powerpc/boot/dts/canyonlands.dts<br>
> +++ b/arch/powerpc/boot/dts/canyonlands.dts<br>
> @@ -360,13 +360,11 @@<br>
> EMAC0: ethernet@ef600e00 {<br>
> device_type = "network";<br>
> compatible = "ibm,emac-460ex", "ibm,emac4sync";<br>
> - interrupt-parent = <&EMAC0>;<br>
> - interrupts = <0x0 0x1>;<br>
> - #interrupt-cells = <1>;<br>
> + interrupt-parent = <&UIC2>;<br>
> #address-cells = <0>;<br>
> #size-cells = <0>;<br>
> - interrupt-map = </*Status*/ 0x0 &UIC2 0x10 0x4<br>
> - /*Wake*/ 0x1 &UIC2 0x14 0x4>;<br>
> + interrupts = </*Status*/0x10 0x4<br>
> + /*Wake*/0x14 0x4>;<br>
> reg = <0xef600e00 0x000000c4>;<br>
> local-mac-address = [000000000000]; /* Filled in by U-Boot */<br>
> mal-device = <&MAL0>;<br>
> @@ -390,13 +388,11 @@<br>
> EMAC1: ethernet@ef600f00 {<br>
> device_type = "network";<br>
> compatible = "ibm,emac-460ex", "ibm,emac4sync";<br>
> - interrupt-parent = <&EMAC1>;<br>
> - interrupts = <0x0 0x1>;<br>
> - #interrupt-cells = <1>;<br>
> + interrupt-parent = <&UIC2>;<br>
> #address-cells = <0>;<br>
> #size-cells = <0>;<br>
> - interrupt-map = </*Status*/ 0x0 &UIC2 0x11 0x4<br>
> - /*Wake*/ 0x1 &UIC2 0x15 0x4>;<br>
> + interrupts = </*Status*/0x11 0x4<br>
> + /*Wake*/0x15 0x4>;<br>
> reg = <0xef600f00 0x000000c4>;<br>
> local-mac-address = [000000000000]; /* Filled in by U-Boot */<br>
> mal-device = <&MAL0>;<br>
> --<br>
> 1.6.1.rc3<br>
><br>
</div></div>> --<br>
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in<br>
> the body of a message to <a href="mailto:majordomo@vger.kernel.org">majordomo@vger.kernel.org</a><br>
> More majordomo info at <a href="http://vger.kernel.org/majordomo-info.html" target="_blank">http://vger.kernel.org/majordomo-info.html</a><br>
> Please read the FAQ at <a href="http://www.tux.org/lkml/" target="_blank">http://www.tux.org/lkml/</a><br>
><br>
</blockquote></div><br>
<pre>CONFIDENTIALITY NOTICE: This e-mail message, including any attachments,
is for the sole use of the intended recipient(s) and contains information
that is confidential and proprietary to AppliedMicro Corporation or its subsidiaries.
It is to be used solely for the purpose of furthering the parties' business relationship.
All unauthorized review, use, disclosure or distribution is prohibited.
If you are not the intended recipient, please contact the sender by reply e-mail
and destroy all copies of the original message.