Ok, the interrupt enabling should happen in the driver. Should it key off compatible or should a new property be added like the existing 5200 clocking property?<br><br><div class="gmail_quote">On Wed, May 6, 2009 at 8:41 PM, Grant Likely <span dir="ltr"><<a href="mailto:grant.likely@secretlab.ca">grant.likely@secretlab.ca</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="im">On Wed, May 6, 2009 at 4:51 PM, Grant Likely <<a href="mailto:grant.likely@secretlab.ca">grant.likely@secretlab.ca</a>> wrote:<br>
> On Wed, May 6, 2009 at 4:19 PM, Wolfgang Denk <<a href="mailto:wd@denx.de">wd@denx.de</a>> wrote:<br>
>> Dear Grant Likely,<br>
>><br>
>> In message <<a href="mailto:fa686aa40905061401k319313c5q89fd3e245c30808f@mail.gmail.com">fa686aa40905061401k319313c5q89fd3e245c30808f@mail.gmail.com</a>> you wrote:<br>
>>> On Wed, May 6, 2009 at 2:15 PM, Wolfgang Denk <<a href="mailto:wd@denx.de">wd@denx.de</a>> wrote:<br>
>>> > From: Piotr Ziecik <<a href="mailto:kosmo@semihalf.com">kosmo@semihalf.com</a>><br>
>>> ><br>
>>> > - Enabled I2C interrupts on MPC5121.<br>
>>> > - Updated Kconfig for i2c-mpc driver.<br>
>>><br>
>>> I think this workaround belongs in the driver itself.<br>
>><br>
>> Sorry, I don't get it. Which workaround? What exactly should I change?<br>
><br>
> Sorry, I misread the patch. Never mind.<br>
<br>
</div>Actually, on 3rd reading, I think my first impression was correct<br>
(even if I was wrong about it being a workaround). This code in<br>
mpc512x_init_i2c() is only relevant for i2c busses (it isn't shared<br>
with any other drivers). Therefore, it belongs with the i2c bus<br>
itself. It does not belong in platform code.<br>
<br>
Cheers,<br>
<div><div></div><div class="h5">g.<br>
<br>
--<br>
Grant Likely, B.Sc., P.Eng.<br>
Secret Lab Technologies Ltd.<br>
</div></div></blockquote></div><br>