<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv=Content-Type content="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 12 (filtered medium)">
<style>
<!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Verdana;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page Section1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.Section1
{page:Section1;}
-->
</style>
<!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang=EN-US link=blue vlink=purple>
<div class=Section1>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>Hi Ilya,<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'> Are you going to push further in submitting the ADMA
driver for 440SPE ? If you are not I am planning to pursue this effort. I
also have couple later version of Soc’s needed to submit.<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>Thank and Regards,<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>Marri<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'><o:p> </o:p></span></p>
<div>
<div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'>
<p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span
style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>
linux-raid-owner@vger.kernel.org [mailto:linux-raid-owner@vger.kernel.org] <b>On
Behalf Of </b>Ilya Yanok<br>
<b>Sent:</b> Thursday, November 13, 2008 9:51 AM<br>
<b>To:</b> Josh Boyer<br>
<b>Cc:</b>; dzu@denx.de; wd@denx.de<br>
<b>Subject:</b> Re: [PATCH 11/11] ppc440spe-adma: ADMA driver for PPC440SP(e)
systems<o:p></o:p></span></p>
</div>
</div>
<p class=MsoNormal><o:p> </o:p></p>
<div>
<p class=MsoNormal style='background:lightblue'><b><span style='font-size:10.0pt;
font-family:"Verdana","sans-serif"'>This message has been archived. <a
href="http://sdcmailvault.ad.amcc.com/EnterpriseVault/ViewMessage.asp?VaultId=1E9560FDB597EB744B7F046F24F9462D91110000sdcmailvault.ad.amcc.com&SavesetId=705000000000000~200811131750430000~2~2007F01CF3764FBC926BAD4B10FE5BC">View
the original item </a><o:p></o:p></span></b></p>
</div>
<div>
<p><span style='font-size:10.0pt;font-family:"Verdana","sans-serif"'>Josh Boyer
wrote:<br>
> On Thu, Nov 13, 2008 at 06:16:04PM +0300, Ilya Yanok wrote:<br>
> <br>
>> Adds the platform device definitions and the architecture specific
support<br>
>> routines for the ppc440spe adma driver.<br>
>><br>
>> Any board equipped with PPC440SP(e) controller may utilize this
driver.<br>
>><br>
>> Signed-off-by: Yuri Tikhonov <yur@emcraft.com><br>
>> Signed-off-by: Ilya Yanok <yanok@emcraft.com><br>
>> <br>
><br>
> Before I really dig into reviewing this driver, I'm going to ask you as
simple<br>
> question. This looks like a 1/2 completed port of an arch/ppc
driver that uses<br>
> the device tree (incorrectly) to get the interrupt resources and that's
about it.<br>
> Otherwise, it's just a straight up platform device driver. Is
that correct?<br>
> <br>
<br>
Yep, that's correct.<br>
<br>
> If that is the case, I think the driver needs more work before it can be
merged.<br>
> It should get the DCR and MMIO resources from the device tree as
well. It should<br>
> be binding on compatible properties and not based on device tree
paths. And it<br>
> should probably be an of_platform device driver.<br>
> <br>
<br>
Surely, you're right. I agree with you in that this driver isn't ready<br>
for merging. But it works so we'd like to publish it so interested<br>
people could use it and test it.<br>
<br>
Regards, Ilya.<br>
<br>
--<br>
To unsubscribe from this list: send the line "unsubscribe linux-raid"
in<br>
the body of a message to majordomo@vger.kernel.org<br>
More majordomo info at http://vger.kernel.org/majordomo-info.html<o:p></o:p></span></p>
</div>
</div>
</body>
</html>