<br><font size=2 face="sans-serif">Hi Roland, </font>
<br><font size=2 face="sans-serif">thanks for the quick review. I was hoping
you could apply these changes for 2.6.30 because this will be the codebase
for the next OFED release.</font>
<br><font size=2 face="sans-serif">The patch is well tested in HPC environment
and we haven't seen any issues.</font>
<br><font size=2 face="sans-serif">Regarding Antons patch you are right.
If a user allocates an unrealistically large queue pair it could happen
that kmalloc() is not able to allocate the memory. In this case we will
return ENOMEM to the user so the kernel will not be affected at all. We
plan to add vmalloc() call in case kmalloc() fails for the next kernel
release.</font>
<br><font size=2 face="sans-serif"> </font>
<br><font size=2 face="sans-serif">Mit freundlichen Grüßen / Kind regards<br>
<br>
Stefan Roscher<br>
<br>
eHCA/eHEA Linux Driver Development<br>
IBM Systems &Technology Group, Systems Software Development / FW I/O
Firmware Entwicklung 2<br>
-------------------------------------------------------------------------------------------------------------------------------------------<br>
IBM Deutschland<br>
Schoenaicher Str. 220<br>
71032 Boeblingen<br>
Phone: +49-7031-16-2015<br>
E-Mail: stefan.roscher@de.ibm.com<br>
-------------------------------------------------------------------------------------------------------------------------------------------<br>
IBM Deutschland Research & Development GmbH / Vorsitzender des Aufsichtsrats:
Martin Jetter<br>
Geschäftsführung: Herbert Kircher<br>
Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart,
HRB 243294</font>
<br>
<br>
<br>
<table width=100%>
<tr valign=top>
<td><font size=1 color=#5f5f5f face="sans-serif">From:</font>
<td><font size=1 face="sans-serif">Roland Dreier <rdreier@cisco.com></font>
<tr valign=top>
<td><font size=1 color=#5f5f5f face="sans-serif">To:</font>
<td><font size=1 face="sans-serif">Stefan Roscher <ossrosch@linux.vnet.ibm.com></font>
<tr>
<td valign=top><font size=1 color=#5f5f5f face="sans-serif">Cc:</font>
<td><font size=1 face="sans-serif">"LinuxPPC-Dev" <linuxppc-dev@ozlabs.org>,
LKML <linux-kernel@vger.kernel.org>, "OF-EWG" <ewg@lists.openfabrics.org>,
Roland Dreier <rolandd@cisco.com>, Joachim Fenkes/Germany/IBM@IBMDE,
Christoph Raisch/Germany/IBM@IBMDE, Alexander Schmidt1/Germany/IBM@IBMDE,
Stefan Roscher/Germany/IBM@IBMDE, Hoang-Nam Nguyen/Germany/IBM@IBMDE</font>
<tr valign=top>
<td><font size=1 color=#5f5f5f face="sans-serif">Date:</font>
<td><font size=1 face="sans-serif">21.04.2009 19:34</font>
<tr valign=top>
<td><font size=1 color=#5f5f5f face="sans-serif">Subject:</font>
<td><font size=1 face="sans-serif">Re: [PATCH 1/3] IB/ehca: Replace vmalloc
with kmalloc</font></table>
<br>
<hr noshade>
<br>
<br>
<br><tt><font size=2> > +
queue->queue_pages = kmalloc(nr_of_pages
* sizeof(void *), GFP_KERNEL);<br>
<br>
How big might this buffer be? Any chance of allocation failure due
to<br>
memory fragmentation?<br>
<br>
- R.<br>
</font></tt>
<br>
<br>