Segher,<br><br>Thank you very much for your review.<br><br>I already re-send this patch as you expect and please check this:<br>[v2 PATCH 1/1] Fix 64bit Maple Host Bridge 'reg' property<br><br>Best Regards<br>Tiejun<br>
<br><div class="gmail_quote">2009/4/14 Segher Boessenkool <span dir="ltr"><<a href="mailto:segher@kernel.crashing.org">segher@kernel.crashing.org</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="im"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
In the DTB tree created by firmware on some Maple 64bit targets, such as ATCA6101,<br>
these two properties, address&size, should be 2.<br>
</blockquote>
<br></div>
And they are.<div class="im"><br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
But the actual corresponding values<br>
of host bridge node are set 1 incorrectly by the firmware, we have to provide one<br>
fixup function to fix that.<br>
</blockquote>
<br></div>
It is the "reg" property that is incorrectly encoded as-if<br>
#address-cells and #size-cells were 1.<br>
<br>
Please fix the commit message (and subject line).<div class="im"><br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
+ name = "/hostbridge@f8000000";<br>
+ hb = call_prom("finddevice", 1, 1, ADDR(name));<br>
</blockquote>
<br></div>
It's interesting that the firmware can find your node this way,<br>
it won't match the "reg"! Looks like there is more than one<br>
bug in there.<br>
<br>
Code looks good,<br>
<br>
Reviewed-by: Segher Boessenkool <<a href="mailto:segher@kernel.crashing.org" target="_blank">segher@kernel.crashing.org</a>><br><font color="#888888">
<br>
<br>
Segher<br>
<br>
</font></blockquote></div><br>