<br><tt><font size=2>Adrian Reber <adrian@lisas.de> wrote on 24.03.2009
13:31:31:<br>
> On Tue, Mar 24, 2009 at 05:30:41PM +1100, Mark Nelson wrote:<br>
> > The buffer passed to the ibm,get-system-parameter RTAS call must
be<br>
> > in the RMA. To ensure we pass an address in the RMA use rtas_data_buf<br>
> > for the actual RTAS call and then copy the result to value. We
can't<br>
> > just make it static because this can be compiled in as a module.<br>
> > <br>
> > Also add the WDRTAS_SP_SPI_LEN so we don't litter '4' throughout
the<br>
> > function.<br>
> > <br>
> > Signed-off-by: Mark Nelson <markn@au1.ibm.com><br>
> > ---<br>
> > <br>
> > Adrian, does this patch cause any problems for your pxcabs?<br>
> <br>
> No, it even helps. I have no tried the watchdog until now, but without
the<br>
> patch I get: <br>
> <br>
> wdrtas: could not get sp_spi watchdog timeout (0). Continuing<br>
> <br>
> and with the patch it reads the correct value. So only with your patch<br>
> it works like it is supposed to. Thanks!<br>
> <br>
> Tested-by: Adrian Reber <adrian@lisas.de></font></tt>
<br>
<br><tt><font size=2>looks good to me.</font></tt>
<br>
<br><tt><font size=2>Acked-by: Utz Bacher <utz.bacher@de.ibm.com></font></tt>
<br>
<br><tt><font size=2>Utz</font></tt>
<br>
<br><tt><font size=2>:wq</font></tt>