<HTML dir=ltr><HEAD><TITLE>Re: [PATCH] ibm_newemac: Add support for GPCS, SGMII and M88E1112PHY</TITLE>
<META http-equiv=Content-Type content="text/html; charset=unicode">
<META content="MSHTML 6.00.2800.1589" name=GENERATOR></HEAD>
<BODY>
<DIV id=idOWAReplyText89008 dir=ltr>
<DIV dir=ltr><FONT face=Arial color=#000000 size=2>
<DIV dir=ltr><FONT face=Arial color=#000000 size=2>Hello Benjamin,</FONT></DIV>
<DIV dir=ltr><FONT face=Arial size=2></FONT> </DIV>
<DIV dir=ltr><FONT face=Arial size=2>On the 460EX/GT in SGMII mode, GPCS access is needed for communication with the internal SGMII SerDes. It is possible that there is still a PHY. So we need a way to access both addresses.</FONT></DIV>
<DIV dir=ltr> </DIV>
<DIV dir=ltr>For Example on the AMCC Arches Board.</DIV>
<DIV dir=ltr> </DIV>
<DIV dir=ltr>EMAC 0 has only a GPCS PHY (address 0xA)</DIV>
<DIV dir=ltr>EMAC 1 has M88E1112 PHY (address 0x0) and GPCS PHY (address 0xB)</DIV>
<DIV dir=ltr>EMAC 2 has M88E1112 PHY (address 0x1) and GPCS PHY (address 0xC)</DIV>
<DIV dir=ltr><FONT face=Arial size=2></FONT> </DIV>
<DIV dir=ltr>Regards,</DIV>
<DIV dir=ltr> </DIV>
<DIV dir=ltr>Victor Gallardo</DIV></FONT></DIV></DIV>
<DIV dir=ltr><BR>
<HR tabIndex=-1>
<FONT face=Tahoma size=2><B>From:</B> Benjamin Herrenschmidt [mailto:benh@kernel.crashing.org]<BR><B>Sent:</B> Sun 9/7/2008 5:29 PM<BR><B>To:</B> Victor Gallardo<BR><B>Cc:</B> linuxppc-dev@ozlabs.org; Feng Kan<BR><B>Subject:</B> Re: [PATCH] ibm_newemac: Add support for GPCS, SGMII and M88E1112PHY<BR></FONT><BR></DIV>
<DIV>
<P><FONT size=2>On Fri, 2008-09-05 at 16:52 -0700, Victor Gallardo wrote:<BR>> From: Victor Gallardo <vgallardo@amcc.com><BR>><BR>> This patch adds GPCS, SGMII and M88E1112 PHY support<BR>> for the AMCC PPC460GT/EX processors.<BR><BR>So if I understand the patch correctly, either there is an *MII PHY in<BR>which case phy_address is used, or there's a GPCS one and phy_address is<BR>-1 and gpcs_address is used right ?<BR><BR>Why not instead always use phy_address, and have a flag indicating<BR>whether it's an MII or GPCS PHY ? This would avoid the added<BR>gpcs_read/write functions, among other things, and I believe would look<BR>cleaner... Or am I missing something ?<BR><BR>Cheers,<BR>Ben.<BR><BR><BR></FONT></P></DIV></BODY></HTML>