I agree, I'll separate the fec_t -> struct fec changes out.<br><br><div class="gmail_quote">On Tue, Jun 17, 2008 at 11:20 PM, Grant Likely <<a href="mailto:grant.likely@secretlab.ca">grant.likely@secretlab.ca</a>> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="Ih2E3d">On Tue, Jun 17, 2008 at 5:03 PM, John Rigby <<a href="mailto:jrigby@freescale.com">jrigby@freescale.com</a>> wrote:<br>
> Fixed all errors and warnings that checkpatch.pl<br>
> reports if this was a new submission.<br>
> Also changed instances of fec_t to struct fec in<br>
> mac-fec.c and mii-fec.c.<br>
<br>
</div>Nit: checkpatch is not law; particularly in the case of whitespace<br>
change. Personally, I think cleaning up whitespace in this regard<br>
causes more problems than it solves. Plus, it makes the important<br>
change (fec_t -> struct fec) get lost in a see of unimportant ones<br>
which makes for hard reviewing.<br>
<br>
But I must sleep now; I'll review your other patch tomorrow.<br>
<br>
Cheers,<br>
g.<br>
<font color="#888888"><br>
--<br>
Grant Likely, B.Sc., P.Eng.<br>
Secret Lab Technologies Ltd.<br>
</font><div><div></div><div class="Wj3C7c">_______________________________________________<br>
Linuxppc-dev mailing list<br>
<a href="mailto:Linuxppc-dev@ozlabs.org">Linuxppc-dev@ozlabs.org</a><br>
<a href="https://ozlabs.org/mailman/listinfo/linuxppc-dev" target="_blank">https://ozlabs.org/mailman/listinfo/linuxppc-dev</a><br>
</div></div></blockquote></div><br>