<br><br><div class="gmail_quote">On Tue, Jun 17, 2008 at 6:35 PM, Stephen Rothwell <<a href="mailto:sfr@canb.auug.org.au">sfr@canb.auug.org.au</a>> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi John,<br>
<br>
You should factor out the fec_t -> struct fec change into an earlier<br>
patch of its own.</blockquote><div>Ok, I'll separate that from the checkpatch fixes. <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<br>
On Tue, 17 Jun 2008 11:48:00 -0600 John Rigby <<a href="mailto:jrigby@freescale.com">jrigby@freescale.com</a>> wrote:<br>
><br>
> +++ b/drivers/net/fs_enet/fec_mpc5121.h<br>
<br>
> +#include <asm/cpm.h> <br></blockquote><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
<br>
Nothing in this file uses anything in asm/cpm.h, so it shouldn't be<br>
included here.</blockquote><div>Ok. <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
<font color="#888888"><br>
--<br>
Cheers,<br>
Stephen Rothwell <a href="mailto:sfr@canb.auug.org.au">sfr@canb.auug.org.au</a><br>
<a href="http://www.canb.auug.org.au/%7Esfr/" target="_blank">http://www.canb.auug.org.au/~sfr/</a><br>
</font><br>_______________________________________________<br>
Linuxppc-dev mailing list<br>
<a href="mailto:Linuxppc-dev@ozlabs.org">Linuxppc-dev@ozlabs.org</a><br>
<a href="https://ozlabs.org/mailman/listinfo/linuxppc-dev" target="_blank">https://ozlabs.org/mailman/listinfo/linuxppc-dev</a><br></blockquote></div><br>