<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>On Jun 16, 2008, at 10:46 AM, Kumar Gala wrote:</div><blockquote type="cite"><div><font class="Apple-style-span" color="#000000"><br></font></div><div>--- a/arch/powerpc/kernel/cputable.c<br>+++ b/arch/powerpc/kernel/cputable.c<br>@@ -1522,6 +1522,21 @@ static struct cpu_spec __initdata cpu_specs[] = {<br> <span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>.machine_check<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>= machine_check_e500,<br> <span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>.platform<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>= "ppc8548",<br> <span class="Apple-tab-span" style="white-space:pre"> </span>},<br>+<span class="Apple-tab-span" style="white-space:pre"> </span>{<span class="Apple-tab-span" style="white-space:pre"> </span>/* e500mc */<br>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>.pvr_mask<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>= 0xffff0000,<br>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>.pvr_value<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>= 0x80230000,<br>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>.cpu_name<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>= "e500mc",<br>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>/* xxx - galak: add CPU_FTR_MAYBE_CAN_DOZE */<br>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>.cpu_features<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>= CPU_FTRS_E500MC,<br>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>.cpu_user_features<span class="Apple-tab-span" style="white-space:pre"> </span>= COMMON_USER_BOOKE | PPC_FEATURE_HAS_FPU,<br>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>.icache_bsize<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>= 64,<br>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>.dcache_bsize<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>= 64,<br>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>.num_pmcs<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>= 4,<br>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>.oprofile_cpu_type<span class="Apple-tab-span" style="white-space:pre"> </span>= "ppc/e500", /* xxx - galak, e500mc? */<br>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>.oprofile_type<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>= PPC_OPROFILE_FSL_EMB,<br>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>.machine_check<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>= machine_check_e500,<br>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>.platform<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>= "ppc4080",<br></div></blockquote><div><br></div><div>Do you really want the platform to be this specific?</div><blockquote type="cite"></blockquote><br><blockquote type="cite"><div>diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype<br>index f7efaa9..9e67cf1 100644<br>--- a/arch/powerpc/platforms/Kconfig.cputype<br>+++ b/arch/powerpc/platforms/Kconfig.cputype<br>@@ -95,6 +95,12 @@ config E500<br> <span class="Apple-tab-span" style="white-space:pre"> </span>select FSL_EMB_PERFMON<br> <span class="Apple-tab-span" style="white-space:pre"> </span>bool<br><br>+config PPC_E500MC<br>+<span class="Apple-tab-span" style="white-space:pre"> </span>bool "e500mc Support"<br>+<span class="Apple-tab-span" style="white-space:pre"> </span>select PPC_FPU<br>+<span class="Apple-tab-span" style="white-space:pre"> </span>depends on E500<br>+<span class="Apple-tab-span" style="white-space:pre"> </span>default n<br>+<br> config PPC_FPU<br> <span class="Apple-tab-span" style="white-space:pre"> </span>bool<br> <span class="Apple-tab-span" style="white-space:pre"> </span>default y if PPC64<br>@@ -157,7 +163,7 @@ config ALTIVEC<br><br> config SPE<br> <span class="Apple-tab-span" style="white-space:pre"> </span>bool "SPE Support"<br>-<span class="Apple-tab-span" style="white-space:pre"> </span>depends on E200 || E500<br>+<span class="Apple-tab-span" style="white-space:pre"> </span>depends on E200 || (E500 && !PPC_E500MC)<br> <span class="Apple-tab-span" style="white-space:pre"></span></div></blockquote><div><br></div><div>Why make E500MC a config option, if it's so similar? This way you can't make a kernel with SPE support that can boot on both e500{,v2} and e500mc...</div><div><br></div><br><blockquote type="cite"><div>config SMP<br>-<span class="Apple-tab-span" style="white-space:pre"> </span>depends on PPC_STD_MMU<br>+<span class="Apple-tab-span" style="white-space:pre"> </span>depends on PPC_STD_MMU || FSL_BOOKE<br> <span class="Apple-tab-span" style="white-space:pre"></span></div></blockquote><div><br></div><div>Isn't there quite a bit more needed than just enabling this config option for SMP to work? I.e. why not save this for when the rest is posted?</div><div><br></div></div><br><div><br></div><div><br></div><div>-Olof</div></body></html>