Use the generic pci_enable_resources() instead of the arch-specific code. Unlike this arch-specific code, the generic version: - checks PCI_NUM_RESOURCES (11), not 6, resources - skips resources that have neither IORESOURCE_IO nor IORESOURCE_MEM set - skips ROM resources unless IORESOURCE_ROM_ENABLE is set - checks for resource collisions with "!r->parent" Signed-off-by: Bjorn Helgaas Index: work8/arch/arm/kernel/bios32.c =================================================================== --- work8.orig/arch/arm/kernel/bios32.c 2008-03-04 09:59:24.000000000 -0700 +++ work8/arch/arm/kernel/bios32.c 2008-03-04 10:01:40.000000000 -0700 @@ -660,28 +660,15 @@ */ int pcibios_enable_device(struct pci_dev *dev, int mask) { + int err; u16 cmd, old_cmd; - int idx; - struct resource *r; + + err = pci_enable_resources(dev, mask); + if (err < 0) + return err; pci_read_config_word(dev, PCI_COMMAND, &cmd); old_cmd = cmd; - for (idx = 0; idx < 6; idx++) { - /* Only set up the requested stuff */ - if (!(mask & (1 << idx))) - continue; - - r = dev->resource + idx; - if (!r->start && r->end) { - printk(KERN_ERR "PCI: Device %s not available because" - " of resource collisions\n", pci_name(dev)); - return -EINVAL; - } - if (r->flags & IORESOURCE_IO) - cmd |= PCI_COMMAND_IO; - if (r->flags & IORESOURCE_MEM) - cmd |= PCI_COMMAND_MEMORY; - } /* * Bridges (eg, cardbus bridges) need to be fully enabled @@ -690,8 +677,8 @@ cmd |= PCI_COMMAND_IO | PCI_COMMAND_MEMORY; if (cmd != old_cmd) { - printk("PCI: enabling device %s (%04x -> %04x)\n", - pci_name(dev), old_cmd, cmd); + dev_info(&dev->dev, "enabling bridge device (%04x -> %04x)\n", + old_cmd, cmd); pci_write_config_word(dev, PCI_COMMAND, cmd); } return 0; --