Use the generic pci_enable_resources() instead of the arch-specific code. Unlike this arch-specific code, the generic version: - checks for resource collisions with "!r->parent" Signed-off-by: Bjorn Helgaas Index: work8/arch/x86/pci/common.c =================================================================== --- work8.orig/arch/x86/pci/common.c 2008-03-04 10:12:42.000000000 -0700 +++ work8/arch/x86/pci/common.c 2008-03-04 10:12:51.000000000 -0700 @@ -527,7 +527,7 @@ { int err; - if ((err = pcibios_enable_resources(dev, mask)) < 0) + if ((err = pci_enable_resources(dev, mask)) < 0) return err; if (!dev->msi_enabled) Index: work8/arch/x86/pci/i386.c =================================================================== --- work8.orig/arch/x86/pci/i386.c 2008-03-04 10:12:56.000000000 -0700 +++ work8/arch/x86/pci/i386.c 2008-03-04 10:13:03.000000000 -0700 @@ -238,44 +238,6 @@ */ fs_initcall(pcibios_assign_resources); -int pcibios_enable_resources(struct pci_dev *dev, int mask) -{ - u16 cmd, old_cmd; - int idx; - struct resource *r; - - pci_read_config_word(dev, PCI_COMMAND, &cmd); - old_cmd = cmd; - for (idx = 0; idx < PCI_NUM_RESOURCES; idx++) { - /* Only set up the requested stuff */ - if (!(mask & (1 << idx))) - continue; - - r = &dev->resource[idx]; - if (!(r->flags & (IORESOURCE_IO | IORESOURCE_MEM))) - continue; - if ((idx == PCI_ROM_RESOURCE) && - (!(r->flags & IORESOURCE_ROM_ENABLE))) - continue; - if (!r->start && r->end) { - printk(KERN_ERR "PCI: Device %s not available " - "because of resource %d collisions\n", - pci_name(dev), idx); - return -EINVAL; - } - if (r->flags & IORESOURCE_IO) - cmd |= PCI_COMMAND_IO; - if (r->flags & IORESOURCE_MEM) - cmd |= PCI_COMMAND_MEMORY; - } - if (cmd != old_cmd) { - printk("PCI: Enabling device %s (%04x -> %04x)\n", - pci_name(dev), old_cmd, cmd); - pci_write_config_word(dev, PCI_COMMAND, cmd); - } - return 0; -} - /* * If we set up a device for bus mastering, we need to check the latency * timer as certain crappy BIOSes forget to set it properly. Index: work8/arch/x86/pci/pci.h =================================================================== --- work8.orig/arch/x86/pci/pci.h 2008-03-04 10:13:08.000000000 -0700 +++ work8/arch/x86/pci/pci.h 2008-03-04 10:13:12.000000000 -0700 @@ -44,7 +44,6 @@ extern unsigned int pcibios_max_latency; void pcibios_resource_survey(void); -int pcibios_enable_resources(struct pci_dev *, int); /* pci-pc.c */ --