<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1">
<META NAME="Generator" CONTENT="MS Exchange Server version 6.5.7652.24">
<TITLE>RE: Problems with PCI on 8280</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/plain format -->
<P><FONT SIZE=2>From: Scott Wood<BR>
<BR>
>Hmm... that suggests that something in u-boot's setup is either<BR>
>incorrect, or (more likely in this case) doesn't match the device tree.<BR>
<BR>
Turns out u-boot was not setting u the inbound window size correctly.<BR>
It was hardcoded to 512MB and we have a gig of ram. Set it correctly, and CPI now works fully even without fixup_pci()<BR>
<BR>
>Ah. Yes, I was assuming both windows would be the same size. The code<BR>
>should be changed to check that, and if any conditions for setting<BR>
>PCIBRx/PCIMSKx fail, check to see if the firmware-provided values work<BR>
>(and if not, bail without touching anything).<BR>
<BR>
yup. In our case we only need one window.<BR>
<BR>
BTW. there is a bug in the inbound window size calculation.<BR>
The mem_log2 variable sould be the shift value, not 1<< shift.<BR>
and on the next line the window size mask sould be anded with 0x000f_ffff before or'ed with 0xa000_0000<BR>
<BR>
</FONT>
</P>
</BODY>
</HTML>