arch/powerpc/platforms/celleb/pci.c | 23 ++++++++++++++++++++--- 1 files changed, 20 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/celleb/pci.c b/arch/powerpc/platforms/celleb/pci.c index 6bc32fd..9b8bb01 100644 --- a/arch/powerpc/platforms/celleb/pci.c +++ b/arch/powerpc/platforms/celleb/pci.c @@ -138,8 +138,6 @@ static void celleb_config_read_fake(unsigned char *config, int where, *val = celleb_fake_config_readl(p); break; } - - return; } static void celleb_config_write_fake(unsigned char *config, int where, @@ -158,7 +156,6 @@ static void celleb_config_write_fake(unsigned char *config, int where, celleb_fake_config_writel(val, p); break; } - return; } static int celleb_fake_pci_read_config(struct pci_bus *bus, @@ -348,9 +345,25 @@ static int __init celleb_setup_fake_pci_device(struct device_node *node, pr_debug("PCI: res assigned 0x%016lx\n", (unsigned long)*res); wi0 = of_get_property(node, "device-id", NULL); + if (unlikely((!wi0))) { + printk(KERN_ERR "PCI: device-id not found.\n"); + goto error; + } wi1 = of_get_property(node, "vendor-id", NULL); + if (unlikely((!wi1))) { + printk(KERN_ERR "PCI: vendor-id not found.\n"); + goto error; + } wi2 = of_get_property(node, "class-code", NULL); + if (unlikely((!wi2))) { + printk(KERN_ERR "PCI: class-code not found.\n"); + goto error; + } wi3 = of_get_property(node, "revision-id", NULL); + if (unlikely((!wi3))) { + printk(KERN_ERR "PCI: revision-id not found.\n"); + goto error; + } celleb_config_write_fake(*config, PCI_DEVICE_ID, 2, wi0[0] & 0xffff); celleb_config_write_fake(*config, PCI_VENDOR_ID, 2, wi1[0] & 0xffff); @@ -372,6 +385,10 @@ static int __init celleb_setup_fake_pci_device(struct device_node *node, celleb_setup_pci_base_addrs(hose, devno, fn, num_base_addr); li = of_get_property(node, "interrupts", &rlen); + if (!li) { + printk(KERN_ERR "PCI: interrupts not found.\n"); + goto error; + } val = li[0]; celleb_config_write_fake(*config, PCI_INTERRUPT_PIN, 1, 1); celleb_config_write_fake(*config, PCI_INTERRUPT_LINE, 1, val);