[EXT] Re: [PATCH v2 1/1] PCI: layerscape: Add the endpoint linkup notifier support

Frank Li frank.li at nxp.com
Tue May 9 07:45:59 AEST 2023


> > > Subject: [EXT] Re: [PATCH v2 1/1] PCI: layerscape: Add the endpoint
> linkup
> > > notifier support
> 
> All these quoted headers are redundant clutter since we've already
> seen them when Manivannan sent his comments.  It would be nice if your
> mailer could be configured to omit them.

Our email client quite stupid. 

> 
> > > > +static int ls_pcie_ep_interrupt_init(struct ls_pcie_ep *pcie,
> > > > +                                  struct platform_device *pdev)
> > > > +{
> > > > +     u32 val;
> > > > +     int ret;
> > > > +
> > > > +     pcie->irq = platform_get_irq_byname(pdev, "pme");
> > > > +     if (pcie->irq < 0) {
> > > > +             dev_err(&pdev->dev, "Can't get 'pme' IRQ\n");
> > >
> > > PME
> >
> > Here should be dts property `pme`, suppose should match
> > platform_get_irq_byname(pdev, "pme");
> 
> You can also edit out all the other context and questions if you're
> not responding to them.
> 
> There were a lot of other comments that were useful but are not
> relevant to this reply.

Okay, I found I mess up patch version number.
 
> 
> Bjorn


More information about the Linuxppc-dev mailing list