[RFC][PATCH] powerpc/book3e: Fix CPU feature handling on e5500

Kumar Gala galak at kernel.crashing.org
Wed Apr 6 22:26:00 EST 2011


On Apr 6, 2011, at 12:41 AM, Stephen Rothwell wrote:

> Hi Kumar,
> 
> On Wed,  6 Apr 2011 00:29:32 -0500 Kumar Gala <galak at kernel.crashing.org> wrote:
>> 
>> * I'm concerned if its ok to assume 'enum' can handle a 64-bit mask or not.
>>  I'm assuming this is the reason that we use a #define on __powerpc64__
> 
> enums are *ints* and therefore 32 bit.  gcc can cope, but warns about it
> (I think). So we must use the #define if any of the included bits are
> above 2^32.

Thanks, I'll rework the patch to use #define.

- k


More information about the Linuxppc-dev mailing list