[PATCH 1/2] PPC4xx: Generelizing drivers/dma/ppc4xx/adma.c

Tirumala Marri tmarri at apm.com
Wed Sep 22 02:51:32 EST 2010


> -----Original Message-----
> From: linuxppc-dev-bounces+tmarri=amcc.com at lists.ozlabs.org
> [mailto:linuxppc-dev-bounces+tmarri=amcc.com at lists.ozlabs.org] On
> Behalf Of Ilya Yanok
> Sent: Sunday, September 19, 2010 1:01 PM
> To: linuxppc-dev at ozlabs.org
> Subject: Re: [PATCH 1/2] PPC4xx: Generelizing drivers/dma/ppc4xx/adma.c
>
> Hi Tirumala,
>
> >  drivers/dma/ppc4xx/adma.c        | 4370 +++-------------------------
> ----------
> >  drivers/dma/ppc4xx/adma.h        |  116 +-
> >  drivers/dma/ppc4xx/ppc4xx-adma.h | 4020
> +++++++++++++++++++++++++++++++++++
>
> You've moved tons of code to the header file. Why?
>
> Regards, Ilya.
>
My intention is to keep the SoC specific code in the header files.
Something iop-dma is also doing.


More information about the Linuxppc-dev mailing list