[PATCH] APM821xx: Add support for new SoC APM821xx

Josh Boyer jwboyer at linux.vnet.ibm.com
Mon Sep 13 23:44:36 EST 2010


On Mon, Sep 06, 2010 at 10:45:26AM -0500, Olof Johansson wrote:
>On Sun, Sep 05, 2010 at 10:19:53PM -0700, Tirumala Marri wrote:
>> >
>> > Then the device tree identifier, and the cpu setup functions, etc,
>> > should indicate
>> > 464, not APM821xx.
>> This is new SoC based on 464 cpu core. All the previous SoC device tree
>> CPU portion uses SoC name.
>
>Hm, you're right. Confusing.
>
>Still, the cpu setup functions would make more sense to have the core
>name in, not the SoC name. Especially since multiple SoC families might
>use the same core, etc.

In theory.  In practice, it just makes it a damn mess.  I'd rather leave
it as-is until we can get a good split-out of the core variants and what
their setup functions might require.  Starting with just this SoC and not
fixing everything else is going to be confusing and probably wrong.

josh


More information about the Linuxppc-dev mailing list