[PATCH 4/16] ps3: system bus minor mmio fix

Christoph Hellwig hch at lst.de
Sun Jan 28 19:42:40 EST 2007


On Sun, Jan 28, 2007 at 07:06:57AM +1100, Benjamin Herrenschmidt wrote:
> On Fri, 2007-01-26 at 19:07 -0800, Geoff Levand wrote:
> > From: Benjamin Herrenschmidt <benh at kernel.crashing.org>
> > 
> > Fix two minor bugs in the PS3 system bus mmio region code.  First, on error or
> > when freeing a region, retain the bus_addr and len fields to allow subsequent
> > calls to create the region.  Second, correct the region address argument to the
> > lv1_unmap_device_mmio_region() call.
> 
> Note that I personally think that drivers/ps3 is a very wrong place for
> the ps3 system bus. It should stay in arch/powerpc/platform/ps3

Yes, absolutely.  We should not spreads things all over the tree do
make understanding the code even more difficult than all the lv1
braindamage already makes it.




More information about the Linuxppc-dev mailing list