Re: [PATCH] fsi: fix bogos error returns from cfam_read and cfam_write

Andrew Jeffery andrew at aj.id.au
Fri Nov 29 09:32:39 AEDT 2019



On Sat, 23 Nov 2019, at 10:01, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> In the case where errors occur in functions cfam_read and cfam_write
> the error return code in rc is not returned and a bogus non-error
> count size is returned instead. Fix this by returning the correct
> error code when an error occurs or the count size if the functions
> worked correctly.
> 
> Addresses-Coverity: ("Unused value")
> Fixes: d1dcd6782576 ("fsi: Add cfam char devices")
> Signed-off-by: Colin Ian King <colin.king at canonical.com>

Reviewed-by: Andrew Jeffery <andrew at aj.id.au>


More information about the linux-fsi mailing list