<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p>On 2026/1/14 16:09, Gao Xiang wrote:</p>
    <blockquote type="cite"
      cite="mid:8cda58e0-e917-4e9c-ae68-d34336deb446@linux.alibaba.com">
      <blockquote type="cite" style="color: #007cff;">
        <blockquote type="cite" style="color: #007cff;">    root->i_uid
          = params && params->fixed_uid < 0 ? getuid() :
          <br>
                      params->fixed_uid;
          <br>
        </blockquote>
        <br>
        will sigfault if `params == NULL`, how about
        <br>
        <br>
             root->i_uid = (!params || params->fixed_uid < 0) ?
        getuid() :
        <br>
                                        params->fixed_uid; <br>
      </blockquote>
    </blockquote>
    <p>Hi Xiang,</p>
    <p>v3 patch sent, however I'm afraid we can't compare fixed_{u,g}id
      with 0,</p>
    <p>as it's of an unsigned type. I've kept ` params->fixed_uid ==
      -1` for now.</p>
    <p><br>
    </p>
    <p>Thanks,</p>
    <p>Yifan</p>
    <blockquote type="cite"
      cite="mid:8cda58e0-e917-4e9c-ae68-d34336deb446@linux.alibaba.com">
      <br>
      Sorry about my braino.
      <br>
      <br>
      Thanks,
      <br>
      Gao Xiang</blockquote>
    <p><br>
    </p>
    <p><br>
    </p>
  </body>
</html>