<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>On 2026/1/14 15:44, Gao Xiang wrote:</p>
<blockquote type="cite"
cite="mid:1e1c7c27-abb5-4f6a-b27c-0f15b9e5da16@linux.alibaba.com">we
could support !im, I mean
<br>
<br>
struct erofs_importer_params *params = im ? im->params :
NULL; <br>
</blockquote>
<p>Hi Xiang,</p>
<p>Do we have any chance `im == NULL` in current codebase? Or is it
to allow for future extensibility?</p>
<blockquote type="cite"
cite="mid:1e1c7c27-abb5-4f6a-b27c-0f15b9e5da16@linux.alibaba.com"><br>
<blockquote type="cite" style="color: #007cff;"> struct
erofs_inode *root;
<br>
@@ -2384,6 +2385,8 @@ struct erofs_inode
*erofs_rebuild_make_root(struct erofs_sb_info *sbi)
<br>
return root;
<br>
root->i_srcpath = strdup("/");
<br>
root->i_mode = S_IFDIR | 0777;
<br>
+ root->i_uid = im->params->fixed_uid == -1 ?
getuid() : im->params->fixed_uid;
<br>
+ root->i_gid = im->params->fixed_gid == -1 ?
getgid() : im->params->fixed_gid;
<br>
</blockquote>
<br>
<br>
<br>
root->i_uid = params && params->fixed_uid < 0
? getuid() :
<br>
params->fixed_uid; <br>
</blockquote>
<p>will sigfault if `params == NULL`, how about</p>
<p> root->i_uid = (!params || params->fixed_uid < 0) ?
getuid() :<br>
params->fixed_uid;</p>
<p><br>
</p>
<p>Thanks,</p>
<p>Yifan</p>
<blockquote type="cite"
cite="mid:1e1c7c27-abb5-4f6a-b27c-0f15b9e5da16@linux.alibaba.com">...
</blockquote>
</body>
</html>