<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<pre>Hi,
</pre>
<div class="moz-cite-prefix">On 2021/9/28 10:33 上午, Gao Xiang wrote:<br>
</div>
<blockquote type="cite" cite="mid:YVJ%2FDVHlUG83A3Jk@B-P7TQMD6M-0146.local">
<pre class="moz-quote-pre" wrap="">Hi,
On Sun, Sep 26, 2021 at 11:21:42AM +0800, Gao Xiang wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Hi Xuenan and Qi,
On Wed, Sep 15, 2021 at 05:35:33PM +0800, Guo Xuenan wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">From: Wang Qi <a class="moz-txt-link-rfc2396E" href="mailto:mpiglet@outlook.com"><mpiglet@outlook.com></a>
Add dump-tool for erofs to facilitate users directly
analyzing the erofs image file.
Signed-off-by: Guo Xuenan <a class="moz-txt-link-rfc2396E" href="mailto:guoxuenan@huawei.com"><guoxuenan@huawei.com></a>
Signed-off-by: Wang Qi <a class="moz-txt-link-rfc2396E" href="mailto:mpiglet@outlook.com"><mpiglet@outlook.com></a>
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
I'm almost fine with the series, and I will merge some of the patches
later.
Due to busy work, my original plan was to fix some nits by myself and
apply. Anyway, I will reply some comments this evening...
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
I've merged the first 2 patches into dev branch with modification (so no
need to resend the first two patches).
The rest patches are still a bit messy, I've set up a new
experimental-dump branch, please check out:
<a class="moz-txt-link-freetext" href="https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs-utils.git/?h=experimental-dump">https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs-utils.git/?h=experimental-dump</a>
There are some stuffs needing to be resolved in advance:
1) rename all "dumpfs_" prefix into "erofsdump_";
2) I feel still uncomfortable when reading get_path_by_nid() and
erofs_read_dir(). Could we refactor them by introducing
erofs_for_each_dir() or likewise?
3) file_category_types and the switch in dumpfs_print_inode() are
duplicated to me. I think one of them can be removed instead.
4) please help using "filefrag -v -b1" style when printing extent info
in erofsdump_show_inode_phy(), like below:
ext: logical_offset: physical_offset: length: expected: flags:
0: 0.. 20479: 21788270592..21788291071: 20480: last,eof
Thanks,
Gao Xiang
</pre>
</blockquote>
<pre>Thanks for your reply! I will refactor the code according to your advice.
Thanks,
Wang Qi</pre>
</body>
</html>