<div dir="ltr"><div dir="ltr"><div>Gao,</div><div><br></div><div>Thanks very much for your help and the prompt reply! Sorry for my mistake, I will resolve and re-submit when I have an appropriate patch series.</div><div><br></div><div>Caitlyn Finn<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Aug 20, 2019 at 8:40 PM Gao Xiang <<a href="mailto:hsiangkao@aol.com">hsiangkao@aol.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Tue, Aug 20, 2019 at 08:18:20PM -0400, Caitlyn wrote:<br>
> Balanced braces to fix some checkpath warnings in inode.c and<br>
> unzip_vle.c<br>
> <br>
> Signed-off-by: Caitlyn <<a href="mailto:caitlynannefinn@gmail.com" target="_blank">caitlynannefinn@gmail.com</a>><br>
> ---<br>
>  drivers/staging/erofs/inode.c     |  4 ++--<br>
>  drivers/staging/erofs/unzip_vle.c | 12 ++++++------<br>
>  2 files changed, 8 insertions(+), 8 deletions(-)<br>
> <br>
> diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c<br>
> index 4c3d8bf..8de6fcd 100644<br>
> --- a/drivers/staging/erofs/inode.c<br>
> +++ b/drivers/staging/erofs/inode.c<br>
> @@ -278,9 +278,9 @@ struct inode *erofs_iget(struct super_block *sb,<br>
>               vi->nid = nid;<br>
>  <br>
>               err = fill_inode(inode, isdir);<br>
> -             if (likely(!err))<br>
> +             if (likely(!err)) {<br>
>                       unlock_new_inode(inode);<br>
<br>
The only valid place is here.<br>
<br>
Thanks,<br>
Gao Xiang<br>
<br>
> -             else {<br>
> +             } else {<br>
>                       iget_failed(inode);<br>
>                       inode = ERR_PTR(err);<br>
>               }<br>
> diff --git a/drivers/staging/erofs/unzip_vle.c b/drivers/staging/erofs/unzip_vle.c<br>
> index f0dab81..f431614 100644<br>
> --- a/drivers/staging/erofs/unzip_vle.c<br>
> +++ b/drivers/staging/erofs/unzip_vle.c<br>
> @@ -915,21 +915,21 @@ static int z_erofs_vle_unzip(struct super_block *sb,<br>
>       mutex_lock(&work->lock);<br>
>       nr_pages = work->nr_pages;<br>
>  <br>
> -     if (likely(nr_pages <= Z_EROFS_VLE_VMAP_ONSTACK_PAGES))<br>
> +     if (likely(nr_pages <= Z_EROFS_VLE_VMAP_ONSTACK_PAGES)) {<br>
>               pages = pages_onstack;<br>
> -     else if (nr_pages <= Z_EROFS_VLE_VMAP_GLOBAL_PAGES &&<br>
> -              mutex_trylock(&z_pagemap_global_lock))<br>
> +     } else if (nr_pages <= Z_EROFS_VLE_VMAP_GLOBAL_PAGES &&<br>
> +              mutex_trylock(&z_pagemap_global_lock)) {<br>
>               pages = z_pagemap_global;<br>
> -     else {<br>
> +     } else {<br>
>  repeat:<br>
>               pages = kvmalloc_array(nr_pages, sizeof(struct page *),<br>
>                                      GFP_KERNEL);<br>
>  <br>
>               /* fallback to global pagemap for the lowmem scenario */<br>
>               if (unlikely(!pages)) {<br>
> -                     if (nr_pages > Z_EROFS_VLE_VMAP_GLOBAL_PAGES)<br>
> +                     if (nr_pages > Z_EROFS_VLE_VMAP_GLOBAL_PAGES) {<br>
>                               goto repeat;<br>
> -                     else {<br>
> +                     } else {<br>
>                               mutex_lock(&z_pagemap_global_lock);<br>
>                               pages = z_pagemap_global;<br>
>                       }<br>
> -- <br>
> 2.7.4<br>
> <br>
> _______________________________________________<br>
> devel mailing list<br>
> <a href="mailto:devel@linuxdriverproject.org" target="_blank">devel@linuxdriverproject.org</a><br>
> <a href="http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel" rel="noreferrer" target="_blank">http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel</a><br>
</blockquote></div></div>