<div dir="auto"><div>Ok perfect! I'll work that way and correct each type in its own individual patch. Thank you again for your patience and your time. </div><div dir="auto"><br></div><div dir="auto">Regards,</div><div dir="auto">Julián Mérida<br><br><div class="gmail_quote" dir="auto"><div dir="ltr" class="gmail_attr">On Mon, Mar 11, 2019, 03:38 Gao Xiang <<a href="mailto:gaoxiang25@huawei.com" target="_blank" rel="noreferrer">gaoxiang25@huawei.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
On 2019/3/11 14:32, Julian Merida wrote:<br>
> Yes, of course! Thank you very much for your kind reply. I only made this simple patch because this is my first patch ever and I didn't know how you used to work.<br>
> <br>
> I will be sending the rest of the patches to you in the next few days.<br>
<br>
Yes, I think it' better to seperate your first patch into different type as well, each type needs one patch.<br>
and it is preferred to fix a type in one patch for all erofs source files if you have extra time (eg, fix 4<br>
checkpatch types in 4 patches for all erofs source code.)<br>
<br>
Thanks,<br>
Gao Xiang<br>
<br>
> <br>
> Best regards, <br>
> Julian Mérida<br>
> <br>
> On Sun, Mar 10, 2019, 04:52 Gao Xiang <<a href="mailto:hsiangkao@aol.com" rel="noreferrer noreferrer" target="_blank">hsiangkao@aol.com</a> <mailto:<a href="mailto:hsiangkao@aol.com" rel="noreferrer noreferrer" target="_blank">hsiangkao@aol.com</a>>> wrote:<br>
> <br>
> Hi Julian,<br>
> <br>
> On 2019/3/10 10:46, Julian Merida wrote:<br>
> > This patch solves various checkpatch check issues<br>
> ><br>
> > Correct indentation on some functions, fix multiple assignments<br>
> > on a single line and brace-placement on a non-single condition statement.<br>
> ><br>
> > Signed-off-by: Julian Merida <<a href="mailto:julianmr97@gmail.com" rel="noreferrer noreferrer" target="_blank">julianmr97@gmail.com</a> <mailto:<a href="mailto:julianmr97@gmail.com" rel="noreferrer noreferrer" target="_blank">julianmr97@gmail.com</a>>><br>
> <br>
> One patch for one type of checkpatch issues? and could you please<br>
> check the other erofs source files as well?<br>
> <br>
> Thanks,<br>
> Gao Xiang<br>
> <br>
> > ---<br>
> > drivers/staging/erofs/inode.c | 33 +++++++++++++++++----------------<br>
> > 1 file changed, 17 insertions(+), 16 deletions(-)<br>
> ><br>
> > diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c<br>
> > index 924b8dfc7a8f..be9bfd04df41 100644<br>
> > --- a/drivers/staging/erofs/inode.c<br>
> > +++ b/drivers/staging/erofs/inode.c<br>
> > @@ -25,7 +25,7 @@ static int read_inode(struct inode *inode, void *data)<br>
> > <br>
> > if (unlikely(vi->data_mapping_mode >= EROFS_INODE_LAYOUT_MAX)) {<br>
> > errln("unknown data mapping mode %u of nid %llu",<br>
> > - vi->data_mapping_mode, vi->nid);<br>
> > + vi->data_mapping_mode, vi->nid);<br>
> > DBG_BUGON(1);<br>
> > return -EIO;<br>
> > }<br>
> > @@ -38,7 +38,7 @@ static int read_inode(struct inode *inode, void *data)<br>
> > <br>
> > inode->i_mode = le16_to_cpu(v2->i_mode);<br>
> > if (S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode) ||<br>
> > - S_ISLNK(inode->i_mode)) {<br>
> > + S_ISLNK(inode->i_mode)) {<br>
> > vi->raw_blkaddr = le32_to_cpu(v2->i_u.raw_blkaddr);<br>
> > } else if (S_ISCHR(inode->i_mode) || S_ISBLK(inode->i_mode)) {<br>
> > inode->i_rdev =<br>
> > @@ -54,10 +54,10 @@ static int read_inode(struct inode *inode, void *data)<br>
> > set_nlink(inode, le32_to_cpu(v2->i_nlink));<br>
> > <br>
> > /* ns timestamp */<br>
> > - inode->i_mtime.tv_sec = inode->i_ctime.tv_sec =<br>
> > - le64_to_cpu(v2->i_ctime);<br>
> > - inode->i_mtime.tv_nsec = inode->i_ctime.tv_nsec =<br>
> > - le32_to_cpu(v2->i_ctime_nsec);<br>
> > + inode->i_mtime.tv_sec = le64_to_cpu(v2->i_ctime);<br>
> > + inode->i_ctime.tv_sec = inode->i_mtime.tv_sec;<br>
> > + inode->i_mtime.tv_nsec = le32_to_cpu(v2->i_ctime_nsec);<br>
> > + inode->i_ctime.tv_nsec = inode->i_mtime.tv_nsec;<br>
> > <br>
> > inode->i_size = le64_to_cpu(v2->i_size);<br>
> > } else if (__inode_version(advise) == EROFS_INODE_LAYOUT_V1) {<br>
> > @@ -68,7 +68,7 @@ static int read_inode(struct inode *inode, void *data)<br>
> > <br>
> > inode->i_mode = le16_to_cpu(v1->i_mode);<br>
> > if (S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode) ||<br>
> > - S_ISLNK(inode->i_mode)) {<br>
> > + S_ISLNK(inode->i_mode)) {<br>
> > vi->raw_blkaddr = le32_to_cpu(v1->i_u.raw_blkaddr);<br>
> > } else if (S_ISCHR(inode->i_mode) || S_ISBLK(inode->i_mode)) {<br>
> > inode->i_rdev =<br>
> > @@ -84,15 +84,15 @@ static int read_inode(struct inode *inode, void *data)<br>
> > set_nlink(inode, le16_to_cpu(v1->i_nlink));<br>
> > <br>
> > /* use build time to derive all file time */<br>
> > - inode->i_mtime.tv_sec = inode->i_ctime.tv_sec =<br>
> > - sbi->build_time;<br>
> > - inode->i_mtime.tv_nsec = inode->i_ctime.tv_nsec =<br>
> > - sbi->build_time_nsec;<br>
> > + inode->i_mtime.tv_sec = sbi->build_time;<br>
> > + inode->i_ctime.tv_sec = inode->i_mtime.tv_sec;<br>
> > + inode->i_mtime.tv_nsec = sbi->build_time_nsec;<br>
> > + inode->i_ctime.tv_nsec = inode->i_mtime.tv_nsec;<br>
> > <br>
> > inode->i_size = le32_to_cpu(v1->i_size);<br>
> > } else {<br>
> > errln("unsupported on-disk inode version %u of nid %llu",<br>
> > - __inode_version(advise), vi->nid);<br>
> > + __inode_version(advise), vi->nid);<br>
> > DBG_BUGON(1);<br>
> > return -EIO;<br>
> > }<br>
> > @@ -173,7 +173,7 @@ static int fill_inode(struct inode *inode, int isdir)<br>
> > <br>
> > if (IS_ERR(page)) {<br>
> > errln("failed to get inode (nid: %llu) page, err %ld",<br>
> > - vi->nid, PTR_ERR(page));<br>
> > + vi->nid, PTR_ERR(page));<br>
> > return PTR_ERR(page);<br>
> > }<br>
> > <br>
> > @@ -260,7 +260,7 @@ static inline struct inode *erofs_iget_locked(struct super_block *sb,<br>
> > }<br>
> > <br>
> > struct inode *erofs_iget(struct super_block *sb,<br>
> > - erofs_nid_t nid, bool isdir)<br>
> > + erofs_nid_t nid, bool isdir)<br>
> > {<br>
> > struct inode *inode = erofs_iget_locked(sb, nid);<br>
> > <br>
> > @@ -270,12 +270,13 @@ struct inode *erofs_iget(struct super_block *sb,<br>
> > if (inode->i_state & I_NEW) {<br>
> > int err;<br>
> > struct erofs_vnode *vi = EROFS_V(inode);<br>
> > +<br>
> > vi->nid = nid;<br>
> > <br>
> > err = fill_inode(inode, isdir);<br>
> > - if (likely(!err))<br>
> > + if (likely(!err)) {<br>
> > unlock_new_inode(inode);<br>
> > - else {<br>
> > + } else {<br>
> > iget_failed(inode);<br>
> > inode = ERR_PTR(err);<br>
> > }<br>
> <br>
</blockquote></div></div></div>