<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body>
<div dir="ltr" style="font-family: "NVIDIA Sans", Arial, Helvetica, sans-serif; font-size: 12pt;">
Hi Andrew and Krzysztof,</div>
<div dir="ltr" style="font-family: "NVIDIA Sans", Arial, Helvetica, sans-serif; font-size: 12pt;">
<br>
</div>
<div dir="ltr" style="font-family: "NVIDIA Sans", Arial, Helvetica, sans-serif; font-size: 16px; color: rgb(0, 0, 0);">
<span style="background-color: rgb(255, 255, 255);">The difference in this device tree is adding more GPIO expanders and changing the networking. </span></div>
<div dir="ltr" style="font-family: "NVIDIA Sans", Arial, Helvetica, sans-serif; font-size: 16px; color: rgb(0, 0, 0);">
<span style="background-color: rgb(255, 255, 255);"><br>
</span></div>
<div dir="ltr" style="font-family: "NVIDIA Sans", Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Would it be best practice to create a new device binding (in this case nvidia,gb200-ut30b), even if it is just a slight modification on gb200nvl-bmc? Or can I reuse the gb200nvl-bmc compatible string and avoid the yaml binding change all together since it would
share the same drivers?</div>
<div dir="ltr" style="font-family: "NVIDIA Sans", Arial, Helvetica, sans-serif; font-size: 12pt;">
<br>
</div>
<div id="ms-outlook-mobile-signature" style="color: inherit; background-color: inherit;">
<p style="margin: 0in; font-family: Calibri, sans-serif; font-size: 11pt;"><span style="font-family: "NVIDIA Sans", sans-serif; font-size: 12pt; color: black; background-color: white;"><b>Donald Shannon<br>
</b>Data Center Systems</span><span style="font-family: "NVIDIA Sans", sans-serif; font-size: 12pt; color: black;"><br>
</span><span style="font-family: "NVIDIA Sans", sans-serif; font-size: 12pt; color: rgb(190, 255, 70); background-color: white;"><b><u><a href="http://www.nvidia.com/" target="_blank" title="http://www.nvidia.com/" data-outlook-id="74b95ab1-c9cd-49be-a323-2d817e96d4b9" style="color: rgb(190, 255, 70); margin-top: 0px; margin-bottom: 0px;">NVIDIA</a></u></b></span></p>
</div>
<div id="mail-editor-reference-message-container" style="color: inherit; background-color: inherit;">
<div class="ms-outlook-mobile-reference-message skipProofing">
<meta name="Generator" content="Microsoft Exchange Server" style="color: inherit; background-color: inherit;">
</div>
<div class="ms-outlook-mobile-reference-message skipProofing" style="text-align: left; padding: 3pt 0in 0in; border-width: 1pt medium medium; border-style: solid none none; border-color: rgb(181, 196, 223) currentcolor currentcolor; font-family: Aptos; font-size: 12pt; color: black;">
<b>From: </b>Andrew Jeffery <andrew@codeconstruct.com.au><br>
<b>Date: </b>Thursday, June 12, 2025 at 00:56<br>
<b>To: </b>Donald Shannon <donalds@nvidia.com>, robh@kernel.org <robh@kernel.org>, krzk+dt@kernel.org <krzk+dt@kernel.org>, conor+dt@kernel.org <conor+dt@kernel.org><br>
<b>Cc: </b>joel@jms.id.au <joel@jms.id.au>, devicetree@vger.kernel.org <devicetree@vger.kernel.org>, linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org>, linux-aspeed@lists.ozlabs.org <linux-aspeed@lists.ozlabs.org>, linux-kernel@vger.kernel.org
<linux-kernel@vger.kernel.org>, Ed Tanous <etanous@nvidia.com><br>
<b>Subject: </b>Re: [PATCH v4 1/1] ARM: dts: aspeed: Add device tree for Nvidia's GB200 UT3.0b platform BMC<br>
<br>
</div>
<div class="PlainText" style="font-size: 11pt;">External email: Use caution opening links or attachments<br>
<br>
<br>
Hi Donald,<br>
<br>
In addition to addressing Krzysztof's comments regarding checkpatch:<br>
<br>
On Tue, 2025-06-10 at 18:30 -0700, Donald Shannon wrote:<br>
> The GB200NVL UT3.0b BMC is an Aspeed Ast2600 based BMC<br>
> for Nvidia Blackwell GB200NVL platform.<br>
<br>
Can you add some words contrasting this platform to the one submitted<br>
by Willie?<br>
<br>
<a href="https://lore.kernel.org/all/20250401153955.314860-3-wthai@nvidia.com/" data-outlook-id="25bb85d4-0d9e-45a9-9d87-75a75b551e41">https://lore.kernel.org/all/20250401153955.314860-3-wthai@nvidia.com/</a><br>
<br>
<br>
> Reference to Ast2600 SOC [1].<br>
> Reference to Blackwell GB200NVL Platform [2].<br>
><br>
> Link: <a href="https://www.aspeedtech.com/server_ast2600/" data-outlook-id="798e12bb-570f-441b-9f24-011735a05fe5">
https://www.aspeedtech.com/server_ast2600/</a> [1]<br>
> Link:<br>
> <a href="https://nvdam.widen.net/s/wwnsxrhm2w/blackwell-datasheet-3384703" data-outlook-id="36bd268c-bf9b-4a43-97af-cb0929bdec04">
https://nvdam.widen.net/s/wwnsxrhm2w/blackwell-datasheet-3384703</a> [2]<br>
><br>
<br>
Please omit the blank line here so the Link: tags are part of the<br>
trailer.<br>
<br>
> Signed-off-by: Donald Shannon <donalds@nvidia.com><br>
> ---<br>
> Changes v1 -> v2:<br>
> - Changed phy-mode to rgmii-id [Lunn]<br>
> - Removed redundant max-speed for mac0 [Lunn]<br>
> - Fixed typo from gb200nvl to gb200 in Makefile<br>
> Changes v2 -> v3:<br>
> - Fixed whitespace issues [Krzysztof]<br>
> - Fixed schema validation issues from my end ( there are still<br>
> issues with the aspeed dtsi file that are not related to this new<br>
> dts) [Herring]<br>
> - Reordered to follow style guide [Krzysztof]<br>
> - Removed redundant status okays<br>
> - Changed vcc to vdd for the power gating on the gpio expanders<br>
> Changes v3 -> v4:<br>
> - Added changelog [Krzysztof]<br>
> - Added nvidia,gb200-ut30b board binding [Krzysztof]<br>
> - Removed unused imports<br>
> - Reordered a couple other style guide violations<br>
> - Added back in a couple needed "status okay"s<br>
> ---<br>
> .../bindings/arm/aspeed/aspeed.yaml | 1 +<br>
> arch/arm/boot/dts/aspeed/Makefile | 1 +<br>
> .../aspeed/aspeed-bmc-nvidia-gb200-ut30b.dts | 1154<br>
> +++++++++++++++++<br>
> 3 files changed, 1156 insertions(+)<br>
> create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-gb200-<br>
> ut30b.dts<br>
><br>
> diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml<br>
> b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml<br>
> index a3736f134130..420fabf05b24 100644<br>
> --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml<br>
> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml<br>
> @@ -98,6 +98,7 @@ properties:<br>
> - inventec,starscream-bmc<br>
> - inventec,transformer-bmc<br>
> - jabil,rbp-bmc<br>
> + - nvidia,gb200-ut30b<br>
<br>
For what it's worth, checkpatch reports at least the following:<br>
<br>
167: WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst<br>
180: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?<br>
193: WARNING: DT compatible string "nvidia,gb200-ut30b" appears un-documented -- check ./Documentation/devicetree/bindings/<br>
<br>
Thanks,<br>
<br>
Andrew<br>
</div>
</div>
</body>
</html>