<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=big5">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Hi Krzk,</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
>Missing commit msg.</div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
></div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
>A nit, subject: drop second/last, redundant "bindings". The</div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
>"dt-bindings" prefix is already stating that these are bindings.</div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
>See also:</div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
>https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18</div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
></div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
>Please use subject prefixes matching the subsystem. You can get them for</div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
>example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory</div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
>your patch is touching. For bindings, the preferred subjects are</div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
>explained here:</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
>https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters</div>
<div class="elementToProof" style="text-align: left; text-indent: 0px; margin: 0px; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Agree, already fixed in another commit in Ryan's series.</div>
<div style="text-align: left; text-indent: 0px; margin: 0px; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<a href="https://patchwork.kernel.org/project/linux-clk/patch/20240808075937.2756733-4-ryan_chen@aspeedtech.com/" id="OWA575e1ac2-732e-ed9d-38b7-64545afc5721" class="OWAAutoLink" style="margin: 0px;">[3/4] dt-bindings: clock: Add AST2700 clock bindings - Patchwork
(kernel.org)</a></div>
<div style="text-align: left; text-indent: 0px; margin: 0px; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
--</div>
<div style="text-align: left; text-indent: 0px; margin: 0px; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Best Regards,</div>
<div style="text-align: left; text-indent: 0px; margin: 0px; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Kevin. Chen</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
<br>
</div>
<div id="appendonsend"></div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<hr style="display: inline-block; width: 98%;">
<div id="divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"><b>寄件者:</b> Krzysztof Kozlowski <krzk@kernel.org><br>
<b>寄件日期:</b> 2024年7月26日 下午 07:11<br>
<b>收件者:</b> Kevin Chen <kevin_chen@aspeedtech.com>; robh@kernel.org <robh@kernel.org>; krzk+dt@kernel.org <krzk+dt@kernel.org>; conor+dt@kernel.org <conor+dt@kernel.org>; joel@jms.id.au <joel@jms.id.au>; andrew@codeconstruct.com.au <andrew@codeconstruct.com.au>;
lee@kernel.org <lee@kernel.org>; catalin.marinas@arm.com <catalin.marinas@arm.com>; will@kernel.org <will@kernel.org>; arnd@arndb.de <arnd@arndb.de>; olof@lixom.net <olof@lixom.net>; soc@kernel.org <soc@kernel.org>; mturquette@baylibre.com <mturquette@baylibre.com>;
sboyd@kernel.org <sboyd@kernel.org>; p.zabel@pengutronix.de <p.zabel@pengutronix.de>; quic_bjorande@quicinc.com <quic_bjorande@quicinc.com>; geert+renesas@glider.be <geert+renesas@glider.be>; dmitry.baryshkov@linaro.org <dmitry.baryshkov@linaro.org>; shawnguo@kernel.org
<shawnguo@kernel.org>; neil.armstrong@linaro.org <neil.armstrong@linaro.org>; m.szyprowski@samsung.com <m.szyprowski@samsung.com>; nfraprado@collabora.com <nfraprado@collabora.com>; u-kumar1@ti.com <u-kumar1@ti.com>; devicetree@vger.kernel.org <devicetree@vger.kernel.org>;
linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org>; linux-aspeed@lists.ozlabs.org <linux-aspeed@lists.ozlabs.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; linux-clk@vger.kernel.org <linux-clk@vger.kernel.org><br>
<b>主旨:</b> Re: [PATCH v1 02/10] dt-binding: clk: ast2700: Add binding for Aspeed AST27xx Clock</span>
<div> </div>
</div>
<div class="elementToProof" style="text-align: left; text-indent: 0px; margin: 0px; font-size: 11pt;">
On 26/07/2024 13:03, Kevin Chen wrote:<br>
> Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com><br>
<br>
Missing commit msg.<br>
<br>
A nit, subject: drop second/last, redundant "bindings". The<br>
"dt-bindings" prefix is already stating that these are bindings.<br>
See also:<br>
<a href="https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18" id="OWAc765d41d-a0f9-b0c5-baad-2beae5ea4795" class="OWAAutoLink" data-auth="NotApplicable">https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18</a><br>
<br>
Please use subject prefixes matching the subsystem. You can get them for<br>
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory<br>
your patch is touching. For bindings, the preferred subjects are<br>
explained here:<br>
<a href="https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters" id="OWA57550013-5513-06f9-de43-2148e49c0b37" class="OWAAutoLink" data-auth="NotApplicable">https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters</a><br>
<br>
> ---<br>
> .../dt-bindings/clock/aspeed,ast2700-clk.h | 180 ++++++++++++++++++<br>
<br>
This is supposed to be part of bindings adding the clock controller.<br>
<br>
> 1 file changed, 180 insertions(+)<br>
> create mode 100644 include/dt-bindings/clock/aspeed,ast2700-clk.h<br>
><br>
> diff --git a/include/dt-bindings/clock/aspeed,ast2700-clk.h b/include/dt-bindings/clock/aspeed,ast2700-clk.h<br>
> new file mode 100644<br>
> index 000000000000..5ca85503736d<br>
> --- /dev/null<br>
> +++ b/include/dt-bindings/clock/aspeed,ast2700-clk.h<br>
> @@ -0,0 +1,180 @@<br>
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */<br>
> +/*<br>
> + * Device Tree binding constants for AST2700 clock controller.<br>
> + *<br>
> + * Copyright (c) 2023 Aspeed Technology Inc.<br>
> + */<br>
> +<br>
> +#ifndef __DT_BINDINGS_CLOCK_AST2700_H<br>
> +#define __DT_BINDINGS_CLOCK_AST2700_H<br>
> +<br>
> +/* SOC0 clk-gate */<br>
> +#define SCU0_CLK_GATE_MCLK (0)<br>
> +#define SCU0_CLK_GATE_ECLK (1)<br>
<br>
Drop all (). Not needed, not useful.<br>
<br>
> +#define SCU0_CLK_GATE_GCLK (2)<br>
> +#define SCU0_CLK_GATE_VCLK (3)<br>
> +#define SCU0_CLK_GATE_BCLK (4)<br>
> +#define SCU0_CLK_GATE_D1CLK (5)<br>
> +#define SCU0_CLK_GATE_REFCLK (6)<br>
> +#define SCU0_CLK_GATE_USB0CLK (7)<br>
> +#define SCU0_CLK_GATE_RSV8 (8)<br>
> +#define SCU0_CLK_GATE_USB1CLK (9)<br>
> +#define SCU0_CLK_GATE_D2CLK (10)<br>
> +#define SCU0_CLK_GATE_RSV11 (11)<br>
> +#define SCU0_CLK_GATE_RSV12 (12)<br>
> +#define SCU0_CLK_GATE_YCLK (13)<br>
> +#define SCU0_CLK_GATE_USB2CLK (14)<br>
> +#define SCU0_CLK_GATE_UART4CLK (15)<br>
> +#define SCU0_CLK_GATE_SLICLK (16)<br>
> +#define SCU0_CLK_GATE_DACCLK (17)<br>
> +#define SCU0_CLK_GATE_DP (18)<br>
> +#define SCU0_CLK_GATE_RSV19 (19)<br>
> +#define SCU0_CLK_GATE_CRT1CLK (20)<br>
> +#define SCU0_CLK_GATE_CRT2CLK (21)<br>
> +#define SCU0_CLK_GATE_VLCLK (22)<br>
> +#define SCU0_CLK_GATE_ECCCLK (23)<br>
> +#define SCU0_CLK_GATE_RSACLK (24)<br>
> +#define SCU0_CLK_GATE_RVAS0CLK (25)<br>
> +#define SCU0_CLK_GATE_UFSCLK (26)<br>
> +#define SCU0_CLK_GATE_EMMCCLK (27)<br>
> +#define SCU0_CLK_GATE_RVAS1CLK (28)<br>
> +/* reserved 29 ~ 31*/<br>
<br>
IDs cannot be reserved. It is a binding, not a hardware number.<br>
<br>
> +#define SOC0_CLK_GATE_NUM (SCU0_CLK_GATE_RVAS1CLK + 1)<br>
<br>
No drop. Others as well.<br>
<br>
Best regards,<br>
Krzysztof<br>
<br>
</div>
************* Email Confidentiality Notice ********************<br>
免責聲明:<br>
本信件(或其附件)可能包含機密資訊，並受法律保護。如 台端非指定之收件者，請以電子郵件通知本電子郵件之發送者, 並請立即刪除本電子郵件及其附件和銷毀所有複印件。謝謝您的合作!<br>
<br>
DISCLAIMER:<br>
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing
the contents. Thank you.
</body>
</html>