<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=big5">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Hi Krzk,</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
>> Hi Krzk,<br>
>><br>
>> In ASPEED, ast2400/2500/2600 use arm architecture with KCONFIG_ARCH_ASPEED which slect MACH_ASPEED_G4/G5/G6 in arch/arm/mach-aspeed/Kconfig.<br>
>> In the fureture, there would be ast2800/2900/... using arm64. We need to clarify the IC generation between 7th/8th/9th/....<br>
>><br>
>> Maybe change ARCH_ASPEED/MACH_ASPEEDG7 to ARCH_ASPEED first.<br>
>> Or, do you have better Kconfig usage?<br>
><br>
>Fix your quotes and do not top-post.<br>
><br>
>Please respond inline, instead of top-posting, because it makes your<br>
>emails hard to follow.</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
><a href="https://elixir.bootlin.com/linux/v6.8-rc7/source/Documentation/process/submitting-patches.rst#L340" id="OWA6b9aa407-24c4-b656-1346-dafd6a770860" class="OWAAutoLink" data-auth="NotApplicable" style="margin: 0px; text-align: left;">https://elixir.bootlin.com/linux/v6.8-rc7/source/Documentation/process/submitting-patches.rst#L340</a></div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
><br>
>><br>
>><br>
>>> +config ARCH_ASPEED<br>
>>> + bool "Aspeed SoC family"<br>
>>> + select MACH_ASPEED_G7<br>
>>> + help<br>
>>> + Say yes if you intend to run on an Aspeed ast2700 or similar<br>
>>> + seventh generation Aspeed BMCs.<br>
>>> +<br>
>>> +config MACH_ASPEED_G7<br>
>>> + bool "Aspeed SoC AST2700"<br>
>><br>
>> There are no MACHines for arm64. Look at this code. Do you see MACH<br>
>> anywhere else? No. Then why Aspeed must be different?<br>
><br>
>What is this?</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
OK. I will remove MACH_ASPEED_G7 and save ARCH_ASPEED for use.</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
--</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Best Regards,</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Kevin. Chen</div>
<div id="appendonsend"></div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<hr style="display: inline-block; width: 98%;">
<div id="divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"><b>寄件者:</b> Krzysztof Kozlowski <krzk@kernel.org><br>
<b>寄件日期:</b> 2024年8月13日 下午 05:48<br>
<b>收件者:</b> Kevin Chen <kevin_chen@aspeedtech.com>; tglx@linutronix.de <tglx@linutronix.de>; robh@kernel.org <robh@kernel.org>; krzk+dt@kernel.org <krzk+dt@kernel.org>; conor+dt@kernel.org <conor+dt@kernel.org>; joel@jms.id.au <joel@jms.id.au>; andrew@codeconstruct.com.au
<andrew@codeconstruct.com.au>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; devicetree@vger.kernel.org <devicetree@vger.kernel.org>; linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org>; linux-aspeed@lists.ozlabs.org
<linux-aspeed@lists.ozlabs.org><br>
<b>主旨:</b> Re: 回覆: [PATCH v1 2/2] irqchip/aspeed-intc: Add support for 10 INTC interrupts on AST27XX platforms</span>
<div> </div>
</div>
<div style="font-size: 11pt;">On 13/08/2024 11:44, Kevin Chen wrote:<br>
> Hi Krzk,<br>
><br>
> In ASPEED, ast2400/2500/2600 use arm architecture with KCONFIG_ARCH_ASPEED which slect MACH_ASPEED_G4/G5/G6 in arch/arm/mach-aspeed/Kconfig.<br>
> In the fureture, there would be ast2800/2900/... using arm64. We need to clarify the IC generation between 7th/8th/9th/....<br>
><br>
> Maybe change ARCH_ASPEED/MACH_ASPEEDG7 to ARCH_ASPEED first.<br>
> Or, do you have better Kconfig usage?<br>
<br>
Fix your quotes and do not top-post.<br>
<br>
Please respond inline, instead of top-posting, because it makes your<br>
emails hard to follow.<br>
<a href="https://elixir.bootlin.com/linux/v6.8-rc7/source/Documentation/process/submitting-patches.rst#L340" id="OWA95b769b0-2b77-2b75-8819-22130c99a81b" class="OWAAutoLink" data-auth="NotApplicable">https://elixir.bootlin.com/linux/v6.8-rc7/source/Documentation/process/submitting-patches.rst#L340</a><br>
<br>
><br>
><br>
>> +config ARCH_ASPEED<br>
>> + bool "Aspeed SoC family"<br>
>> + select MACH_ASPEED_G7<br>
>> + help<br>
>> + Say yes if you intend to run on an Aspeed ast2700 or similar<br>
>> + seventh generation Aspeed BMCs.<br>
>> +<br>
>> +config MACH_ASPEED_G7<br>
>> + bool "Aspeed SoC AST2700"<br>
><br>
> There are no MACHines for arm64. Look at this code. Do you see MACH<br>
> anywhere else? No. Then why Aspeed must be different?<br>
<br>
What is this?<br>
<br>
><br>
> --<br>
> Best Regards,<br>
> Kevin. Chen<br>
><br>
> ________________________________<br>
> 寄件者: Krzysztof Kozlowski <krzk@kernel.org><br>
> 寄件日期: 2024年8月13日 下午 04:50<br>
> 收件者: Kevin Chen <kevin_chen@aspeedtech.com>; tglx@linutronix.de <tglx@linutronix.de>; robh@kernel.org <robh@kernel.org>; krzk+dt@kernel.org <krzk+dt@kernel.org>; conor+dt@kernel.org <conor+dt@kernel.org>; joel@jms.id.au <joel@jms.id.au>; andrew@codeconstruct.com.au
<andrew@codeconstruct.com.au>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; devicetree@vger.kernel.org <devicetree@vger.kernel.org>; linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org>; linux-aspeed@lists.ozlabs.org
<linux-aspeed@lists.ozlabs.org><br>
> 主旨: Re: [PATCH v1 2/2] irqchip/aspeed-intc: Add support for 10 INTC interrupts on AST27XX platforms<br>
><br>
<br>
...<br>
<br>
>> diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile<br>
>> index 15635812b2d6..d2fe686ae018 100644<br>
>> --- a/drivers/irqchip/Makefile<br>
>> +++ b/drivers/irqchip/Makefile<br>
>> @@ -84,6 +84,7 @@ obj-$(CONFIG_MVEBU_SEI) += irq-mvebu-sei.o<br>
>> obj-$(CONFIG_LS_EXTIRQ) += irq-ls-extirq.o<br>
>> obj-$(CONFIG_LS_SCFG_MSI) += irq-ls-scfg-msi.o<br>
>> obj-$(CONFIG_ARCH_ASPEED) += irq-aspeed-vic.o irq-aspeed-i2c-ic.o irq-aspeed-scu-ic.o<br>
>> +obj-$(CONFIG_MACH_ASPEED_G7) += irq-aspeed-intc.o<br>
><br>
> There is no such thing as CONFIG_MACH_ASPEED_G7. And there will never be.<br>
><br>
> You already received feedback on this, so why do you keep pushing your<br>
> solution? You did not respond to any feedback given, just send the same<br>
> and the same till we agree?<br>
><br>
> NAK.<br>
<br>
And this?<br>
<br>
><br>
>> obj-$(CONFIG_STM32MP_EXTI) += irq-stm32mp-exti.o<br>
>> obj-$(CONFIG_STM32_EXTI) += irq-stm32-exti.o<br>
>> obj-$(CONFIG_QCOM_IRQ_COMBINER) += qcom-irq-combiner.o<br>
>> diff --git a/drivers/irqchip/irq-aspeed-intc.c b/drivers/irqchip/irq-aspeed-intc.c<br>
>> new file mode 100644<br>
>> index 000000000000..71407475fb27<br>
><br>
<br>
...<br>
<br>
><br>
> ************* Email Confidentiality Notice ********************<br>
> 免責聲明:<br>
> 本信件(或其附件)可能包含機密資訊，並受法律保護。如 台端非指定之收件者，請以電子郵件通知本電子郵件之發送者, 並請立即刪除本電子郵件及其附件和銷毀所有複印件。謝謝您的合作!<br>
><br>
> DISCLAIMER:<br>
> This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing
the contents. Thank you.<br>
<br>
Maybe I am the intended recipient of your message, maybe not. I don't<br>
want to have any legal questions regarding upstream, public<br>
collaboration, thus probably I should just remove your messages.<br>
<br>
Please talk with your IT that such disclaimers in open-source are not<br>
desired (and maybe even harmful).<br>
If you do not understand why, please also see:<br>
<a href="https://www.youtube.com/live/fMeH7wqOwXA?si=GY7igfbda6vnjXlJ&t=835" id="OWAc263736f-4270-8e2c-08f5-9dff08073e5e" class="OWAAutoLink" data-auth="NotApplicable">https://www.youtube.com/live/fMeH7wqOwXA?si=GY7igfbda6vnjXlJ&t=835</a><br>
<br>
If you need to go around company SMTP server, then consider using b4<br>
web-relay: <a href="https://b4.docs.kernel.org/en/latest/contributor/send.html" id="OWA671c3a5a-885a-7218-8417-418f46e7a831" class="OWAAutoLink" data-auth="NotApplicable">
https://b4.docs.kernel.org/en/latest/contributor/send.html</a><br>
<br>
Please be informed that by responding to this email you agree that all<br>
communications from you and/or your company is made public. In other<br>
words, all messages originating from you and/or your company will be<br>
made public.<br>
<br>
You already received exactly this feedback. Around three times. If you<br>
keep ignoring feedback, I will keep NAKing your patches.<br>
<br>
Best regards,<br>
Krzysztof<br>
<br>
</div>
************* Email Confidentiality Notice ********************<br>
免責聲明:<br>
本信件(或其附件)可能包含機密資訊，並受法律保護。如 台端非指定之收件者，請以電子郵件通知本電子郵件之發送者, 並請立即刪除本電子郵件及其附件和銷毀所有複印件。謝謝您的合作!<br>
<br>
DISCLAIMER:<br>
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing
the contents. Thank you.
</body>
</html>