<div dir="ltr">Hi Krzysztof,<div><div style="background-color:#fff"> </div><br> <div class="gmail_default" style="margin-left:0.6rem;padding-top:0.4rem;padding-bottom:0.4rem;padding-left:0.8em;padding-right:1.2rem;background-color:#e9f3ff;color:#222;display:inline-block;border-radius:5px"><span class="">> +<br>
> +&i2c15 {<br>
> +     status = "okay";<br>
> +<br>
> +     eeprom@50 {<br>
> +             compatible = "atmel,24c128";<br>
> +             reg = <0x50>;<br>
> +     };<br>
> +};<br>
> +<br>
> +&adc0 {<br>
> +     ref_voltage = <2500>;<br>
<br></span>
There is no such property in the bindings.<span class="im"><br>
<br>
> +     status = "okay";<br>
> +     pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default<br>
> +             &pinctrl_adc2_default &pinctrl_adc3_default<br>
> +             &pinctrl_adc4_default &pinctrl_adc5_default<br>
> +             &pinctrl_adc6_default &pinctrl_adc7_default>;<br>
> +};<br>
> +<br>
> +&adc1 {<br>
> +     ref_voltage = <2500>;<br>
<br></span>
NAK, there is no such property.</div> <div style="background-color:#fff"></div> <br></div><div>Thanks for your advice, I will change this property to "aspeed,int-vref-microvolt" which is defined in the binding in the v2 patch.</div><div><br></div><div>Thanks,</div><div>Yang Chen<br><div><br></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Krzysztof Kozlowski <<a href="mailto:krzysztof.kozlowski@linaro.org">krzysztof.kozlowski@linaro.org</a>> 於 2023年9月13日 週三 下午6:04寫道：<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 12/09/2023 16:05, <a href="mailto:yangchen.openbmc@gmail.com" target="_blank">yangchen.openbmc@gmail.com</a> wrote:<br>
> From: Yang Chen <<a href="mailto:yangchen.openbmc@gmail.com" target="_blank">yangchen.openbmc@gmail.com</a>><br>
> <br>
> Add linux device tree entry related to the Minerva Chassis Management<br>
> Controller (CMC) specific devices connected to the Aspeed SoC (AST2600).<br>
> <br>
> Signed-off-by: Yang Chen <<a href="mailto:yangchen.openbmc@gmail.com" target="_blank">yangchen.openbmc@gmail.com</a>><br>
> ---<br>
>  arch/arm/boot/dts/aspeed/Makefile             |   1 +<br>
>  .../aspeed-bmc-facebook-minerva-cmc.dts       | 265 ++++++++++++++++++<br>
>  2 files changed, 266 insertions(+)<br>
>  create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-minerva-cmc.dts<br>
> <br>
> diff --git a/arch/arm/boot/dts/aspeed/Makefile b/arch/arm/<br>
<br>
<br>
> +<br>
> +&i2c15 {<br>
> +     status = "okay";<br>
> +<br>
> +     eeprom@50 {<br>
> +             compatible = "atmel,24c128";<br>
> +             reg = <0x50>;<br>
> +     };<br>
> +};<br>
> +<br>
> +&adc0 {<br>
> +     ref_voltage = <2500>;<br>
<br>
There is no such property in the bindings.<br>
<br>
> +     status = "okay";<br>
> +     pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default<br>
> +             &pinctrl_adc2_default &pinctrl_adc3_default<br>
> +             &pinctrl_adc4_default &pinctrl_adc5_default<br>
> +             &pinctrl_adc6_default &pinctrl_adc7_default>;<br>
> +};<br>
> +<br>
> +&adc1 {<br>
> +     ref_voltage = <2500>;<br>
<br>
NAK, there is no such property.<br>
<br>
<br>
<br>
Best regards,<br>
Krzysztof<br>
<br>
</blockquote></div>