<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:PMingLiU;
panose-1:2 2 5 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@PMingLiU";
panose-1:2 1 6 1 0 1 1 1 1 1;}
@font-face
{font-family:"\@DengXian";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:10.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
mso-ligatures:none;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="en-TW" link="blue" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<div id="mail-editor-reference-message-container">
<div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt">On Thu, Aug 17, 2023 at 08:00:28PM +0800, Billy Tsai wrote:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> Document the compatible for aspeed,ast2600-pwm-tach device, which can<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> support upto 16 PWM outputs and 16 fan tach input.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> ---<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> .../bindings/hwmon/aspeed,g6-pwm-tach.yaml | 57 +++++++++++++++++++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> 1 file changed, 57 insertions(+)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> create mode 100644 Documentation/devicetree/bindings/hwmon/aspeed,g6-pwm-tach.yaml<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> diff --git a/Documentation/devicetree/bindings/hwmon/aspeed,g6-pwm-tach.yaml b/Documentation/devicetree/bindings/hwmon/aspeed,g6-pwm-tach.yaml<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> new file mode 100644<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> index 000000000000..1666304d0b0f<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> --- /dev/null<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> +++ b/Documentation/devicetree/bindings/hwmon/aspeed,g6-pwm-tach.yaml<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> @@ -0,0 +1,57 @@<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> +# Copyright (C) 2021 Aspeed, Inc.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> +%YAML 1.2<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> +---<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> +$id: http://devicetree.org/schemas/hwmon/aspeed,g6-pwm-tach.yaml#<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> +$schema: http://devicetree.org/meta-schemas/core.yaml#<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> +<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> +title: ASPEED G6 PWM and Fan Tach controller device driver<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> +<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> +maintainers:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> + - Billy Tsai <billy_tsai@aspeedtech.com><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> +<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> +description: |<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> + The ASPEED PWM controller can support upto 16 PWM outputs.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> + The ASPEED Fan Tacho controller can support upto 16 fan tach input.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> +<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> +properties:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> + compatible:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> + enum:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> + - aspeed,ast2600-pwm-tach<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> +<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> + reg:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> + maxItems: 1<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> +<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> + clocks:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> + maxItems: 1<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> +<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> + resets:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> + maxItems: 1<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> +<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> + "#pwm-cells":<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> + const: 3<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> +<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> + aspeed,fan-tach-ch:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> + description: Specify the Fan tach input channels.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>> + $ref: "/schemas/types.yaml#/definitions/uint8-array"<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>This property is already defined in aspeed-pwm-tacho.txt as a single u8
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>that goes in a fan node. You can't redefine its type and location here.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Hi Rob, <o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">I didn't redefine the</span><span lang="EN-US" style="font-size:11.0pt"> type of</span><span style="font-size:11.0pt"> property. The type of the aspeed,fan-tach-ch is unit8-array<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">in aspeed-pwm-tacho.txt.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt#L48<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt#L71<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>To repeat what I've said in previous versions, work with others to
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>define a common fan and fan controller binding. Otherwise, anything new
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">>with fan related properties is simply going to be rejected.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt">Okay I will try to work with Naresh for defining a common fan binding.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt">Thanks for your suggestion.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt">Hi Naresh,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt">As Rob mentioned, it would be advisable for my dt-bindings to reference the common fan bindings instead of introducing specific properties.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt">I noticed that you have already submitted a related patch to the community, which seems to be pending for around 10 months.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><a href="https://lore.kernel.org/lkml/20221116213615.1256297-2-Naresh.Solanki@9elements.com/">https://lore.kernel.org/lkml/20221116213615.1256297-2-Naresh.Solanki@9elements.com/</a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt">Do you have plans to send the next version of the patch? Alternatively, can I proceed to cherry-pick this version of the patch and continue with<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt">the upstreaming process in my patch serial?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Thanks<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Best Regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Billy Tsai<o:p></o:p></span></p>
</div>
</div>
</div>
</div>
</body>
</html>