<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:PMingLiU;
panose-1:2 2 5 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@PMingLiU";
panose-1:2 1 6 1 0 1 1 1 1 1;}
@font-face
{font-family:"\@DengXian";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:10.0pt;
font-family:"Calibri",sans-serif;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
mso-ligatures:none;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="en-TW" link="blue" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt"> On 06/06/2023 16:06, Patrick Williams wrote:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >> On Tue, Jun 06, 2023 at 12:49:04PM +0200, Krzysztof Kozlowski wrote:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >> Hi Krzysztof,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >> Thank you for reviewing this from Billy.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >> The Aspeed chip is heavily used by the OpenBMC community and the 2600<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >> has been used in production systems for almost 2 years now. Many<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >> companies are having to carry previous versions of these as patches, and<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >> some of the APIs changed since the last revision from Billy. So, I had<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >> asked him to submit the latest patch set with as many revisions as he<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >> understood what to change, since the conversation seemed to have died<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >> since last time he submitted.
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >> I don't believe Billy is intentionally ignoring your feedback and he is<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >> motivated to get this patch set wrapped up into an acceptable state.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >>> On 06/06/2023 11:45, Billy Tsai wrote:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >>> NAK. You got here clear comment. You cannot have simple MFD with<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >>> resources. It is not simple anymore.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >>><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >> In fairness, Billy asked for clarification from you on this point and didn't<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >> receive it.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >> https://lore.kernel.org/lkml/24DD1FEB-95F3-47BE-BE61-8B0E6FBDE20F@aspeedtech.com/<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> > I gave the instruction what Billy should do:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> > https://lore.kernel.org/lkml/41500a04-b004-0e2c-20a1-3a3092b90e6d@linaro.org/<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> > What about other ignored comments? About subject, quotes and more? Even<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> > if this one was unclear, then why ignoring all the rest?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">It's possible that there was some confusion regarding your message. I apologize for any misunderstanding.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">About the subject: I apologize for the misunderstanding. I just drop the redundant "bindings" in the commit message.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">About the quotes: I believe the issue was simply related to the order of the patches, and I have resolved it. Did I misunderstand?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">About the Missing description:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> +patternProperties:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> + "^fan@[a-z0-9]+$":<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> + type: object<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> Missing description. But more important - why do you have such child<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> nodes? Your example does not have them. What's the point? Do you expect<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> different number of fans per one device (one compatible)?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">In this patch series, I have included examples and descriptions to provide additional information.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">The child node is used to enable the channel of this tach controller.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">I expect that the dts will include information regarding the number of fans connected to the board and their corresponding channels.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >> He felt what he was trying to accomplish met the documented<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >> expectations. Are there some changes that need to be done in mfd.txt to<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> >> further clarify when to use it and when not to?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> > I think mfd.txt clearly states:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> > "For more complex devices, when the nexus driver has to<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> > probe registers to figure out what child devices exist etc, this should<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> > not be used. In the latter case the child devices will be determined by<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> > the operating system."<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">About the mfd</span><span lang="EN-US" style="font-size:11.0pt">:
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt">For our </span><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:ZH-TW">p</span><span lang="EN-US" style="font-size:11.0pt">wm and tach devices, there is no need to check/apply any
hardware register from parent to determine child’s existence or functional.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt">They</span><span style="font-size:11.0pt"> do</span><span lang="EN-US" style="font-size:11.0pt">n’t</span><span style="font-size:11.0pt"> have any dependency on the parent node</span><span lang="EN-US" style="font-size:11.0pt">.
In fact, it </span><span style="font-size:11.0pt">do</span><span lang="EN-US" style="font-size:11.0pt">esn’t</span><span style="font-size:11.0pt"> require a specific driver to bind with the "aspeed,ast2600-pwm-tach" label. Their purpose is solely to share
the same clock, reset </span><span lang="EN-US" style="font-size:11.0pt">phandle
</span><span style="font-size:11.0pt">and base address.</span><span style="font-size:11.0pt">
<span lang="EN-US">The main reason for using simple-mfd in this case is because these two independent devices share the same base address. In fact, I can relocate the clock and reset configurations to the child nodes rather than the parent node. In this case,
I still can't use simple-mfd?<o:p></o:p></span></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:ZH-TW"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:ZH-TW">I appreciate your assistance and review.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:ZH-TW"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:ZH-TW">Best Regards,
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:ZH-TW">Billy Tsai<o:p></o:p></span></p>
</div>
</div>
</body>
</html>