<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body style="overflow-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;"><br><div><br><blockquote type="cite"><div>On Dec 25, 2022, at 11:45 PM, Potin Lai <potin.lai.pt@gmail.com> wrote:</div><br class="Apple-interchange-newline"><div><div>In OpenBMC, phosphor-software-manager use "alt-bmc" for secondary falsh<br>label.<br>Rename flash1 label to "alt-bmc" to support dual image feature inOpenBMC.<br><br>Signed-off-by: Potin Lai <potin.lai.pt@gmail.com><br>---<br> arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br><br>diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts<br>index a619eec70633..791f83aaac50 100644<br>--- a/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts<br>+++ b/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts<br>@@ -307,7 +307,7 @@ flash@0 {<br> <span class="Apple-tab-span" style="white-space:pre"> </span>flash@1 {<br> <span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>status = "okay";<br> <span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>m25p,fast-read;<br>-<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>label = "flash1";<br>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>label = "alt-bmc";<br> <span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>spi-max-frequency = <50000000>;<br></div></div></blockquote><div><br></div><div>This is correct, and I see it’s been merged into 6.3. </div><div>Just something you may want do to as a follow-up change to add the partitions to the alternate flash device. Similar to the include line for:</div><div><br></div><div>flash@0{</div><div>…</div><div>label = “bmc”</div><div>...</div><div>#include "openbmc-flash-layout-128.dtsi”</div><div>};</div><div><br></div><div>You probably want an include for the alt partitions and add this include line at the end:</div><div>flash@1{</div><div>…</div><div>label = “alt-bmc”;</div><div>...</div><div>+ #include "openbmc-flash-layout-128-alt.dtsi”</div><div>};</div><div><br></div><div>There’s not a file "openbmc-flash-layout-128-alt.dtsi” that exists today, so you’d need to create it by copying it the existing "openbmc-flash-layout-128.dtsi” and just add an “alt-“ prefix to the partition labels, this is the change that was done to create the file "openbmc-flash-layout-64-alt.dtsi” for 64MB flash chips as an example: <a href="https://lore.kernel.org/openbmc/Yboga8RUoYrXoPB1@heinlein/t/#maca042c23241f765fc2aaaa9d90131ee69b8cf81">https://lore.kernel.org/openbmc/Yboga8RUoYrXoPB1@heinlein/t/#maca042c23241f765fc2aaaa9d90131ee69b8cf81</a></div><div><br></div><div>The function that you gain by adding “alt-“ partitions to the secondary flash device is that the phosphor-software-manager code will auto-mount the partitions including the read-write filesystem for syncing/backup and also create the d-bus version interfaces for this secondary flash device.</div><div><br></div><div>This is probably more information that you’d want, but you may had noticed that IBM’s 128MB tacoma system "aspeed-bmc-opp-tacoma.dts” does not have partitions for the secondary device, and the reason is that the 2nd NOR chip is not used, instead we have an eMMC card attached and use the u-boot partition from the primary NOR flash device. Otherwise we would had created the "openbmc-flash-layout-128-alt.dtsi” file already.</div><br><blockquote type="cite"><div><div> <span class="Apple-tab-span" style="white-space:pre"> </span>};<br> };<br>-- <br>2.31.1<br><br></div></div></blockquote></div><br></body></html>