<div dir="ltr">Noted. <br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Sep 6, 2022 at 11:57 AM Tao Ren <<a href="mailto:rentao.bupt@gmail.com">rentao.bupt@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Karthikeyan,<br>
<br>
I don't have much experience with ipmb-dev, but I'd suggest updating the<br>
patch tile so it's consistent with other dts patches. For example:<br>
<br>
"ARM: dts: aspeed: yosemitev2: Enable i2c13 controller"<br>
<br>
<br>
Cheers,<br>
<br>
- Tao<br>
<br>
On Tue, Sep 06, 2022 at 10:37:02AM +0530, Karthikeyan Pasupathi wrote:<br>
> Added IPMB-13 channel for Debug Card communication.<br>
> <br>
> ---<br>
> --- v1 - Initial draft.<br>
> ---<br>
> <br>
> Signed-off-by: Karthikeyan Pasupathi <<a href="mailto:pkarthikeyan1509@gmail.com" target="_blank">pkarthikeyan1509@gmail.com</a>><br>
> ---<br>
>  arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts | 11 +++++++++++<br>
>  1 file changed, 11 insertions(+)<br>
> <br>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts<br>
> index 8864e9c312a8..84236df522dc 100644<br>
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts<br>
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts<br>
> @@ -215,6 +215,17 @@<br>
>       };<br>
>  };<br>
>  <br>
> +&i2c13 {<br>
> +     status = "okay";<br>
> +     // Debug Card<br>
> +     multi-master;<br>
> +     ipmb13@10 {<br>
> +             compatible = "ipmb-dev";<br>
> +             reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;<br>
> +             i2c-protocol;<br>
> +     };<br>
> +};<br>
> +<br>
>  &pwm_tacho {<br>
>       status = "okay";<br>
>       //FSC<br>
> -- <br>
> 2.17.1<br>
> <br>
</blockquote></div>