<div dir="ltr">Noted. <br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Aug 23, 2022 at 5:31 AM Joel Stanley <<a href="mailto:joel@jms.id.au">joel@jms.id.au</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Mon, 22 Aug 2022 at 07:02, Karthikeyan Pasupathi<br>
<<a href="mailto:pkarthikeyan1509@gmail.com" target="_blank">pkarthikeyan1509@gmail.com</a>> wrote:<br>
><br>
> This patch includes the following updates for Yosemite V2<br>
> BMC.<br>
><br>
> 1) Updated GPIO configuration for power control.<br>
<br>
Please take a look the openbmc naming conventions for the GPIOs. If<br>
you are not going to follow them, please explain why in your commit<br>
message.<br>
<br>
<br>
> 2) Added IPMB-13 channel for Debug Card communication.<br>
> 3) Removed EEPROM driver IPMB-12 channel and keeping it as<br>
>    "status ok".<br>
<br>
If you find yourself writing a commit log that contains 1), 2), 3)<br>
then there's a fair chance you could have sent three separate patches.<br>
Consider this for next time.<br>
<br>
><br>
> Signed-off-by: Karthikeyan Pasupathi <<a href="mailto:pkarthikeyan1509@gmail.com" target="_blank">pkarthikeyan1509@gmail.com</a>><br>
> ---<br>
>  .../dts/aspeed-bmc-facebook-yosemitev2.dts    | 49 +++++++++++++++++--<br>
>  1 file changed, 44 insertions(+), 5 deletions(-)<br>
><br>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts<br>
> index 8864e9c312a8..4d2ff7eb6740 100644<br>
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts<br>
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts<br>
> @@ -119,6 +119,40 @@<br>
>                         &pinctrl_adc15_default>;<br>
>  };<br>
><br>
> +&gpio {<br>
> +       status = "okay";<br>
> +       gpio-line-names =<br>
> +       /*A0-A7*/   "","","","","","","","",<br>
> +       /*B0-B7*/   "","","","","","","","",<br>
> +       /*C0-C7*/   "","","","","","","","",<br>
> +       /*D0-D7*/   "POWER_BUTTON","POWER_OUT1","","POWER_OUT2","","POWER_OUT3","","POWER_OUT4",<br>
> +       /*E0-E7*/   "DEBUG_UART_SEL0","DEBUG_UART_SEL1","DEBUG_UART_SEL2","DEBUG_UART_RX_SEL_N","","","","",<br>
> +       /*F0-F7*/   "","","","","","","","",<br>
> +       /*G0-G7*/   "LED_POST_CODE_0","LED_POST_CODE_1","LED_POST_CODE_2","LED_POST_CODE_3","","","","",<br>
> +       /*H0-H7*/   "","","","","","","","",<br>
> +       /*I0-I7*/   "SLOT1_POWER_OK","SLOT2_POWER_OK","SLOT3_POWER_OK","SLOT4_POWER_OK","","","","",<br>
> +       /*J0-J7*/   "","","","","","","","",<br>
> +       /*K0-K7*/   "","","","","","","","",<br>
> +       /*L0-L7*/   "","","","","","","","",<br>
> +       /*M0-M7*/   "","","","","","","","",<br>
> +       /*N0-N7*/   "","","I2C_SLOT1","I2C_SLOT2","I2C_SLOT3","I2C_SLOT4","","",<br>
> +       /*O0-O7*/   "","","","SELECTOR_BUTTON","SLOT1_POWER","SLOT2_POWER","SLOT3_POWER","SLOT4_POWER",<br>
> +       /*P0-P7*/   "","","","","LED_POST_CODE_4","LED_POST_CODE_5","LED_POST_CODE_6","LED_POST_CODE_7",<br>
> +       /*Q0-Q7*/   "","","","","","","","",<br>
> +       /*R0-R7*/   "","","","GPIO_DBG_CARD_PRSNT","","","","",<br>
> +       /*S0-S7*/   "RESET_OUT1","RESET_OUT2","RESET_OUT3","RESET_OUT4","","","","",<br>
> +       /*T0-T7*/   "","","","","","","","",<br>
> +       /*U0-U7*/   "","","","","","","","",<br>
> +       /*V0-V7*/   "","","","","","","","",<br>
> +       /*W0-W7*/   "","","","","","","","",<br>
> +       /*X0-X7*/   "","","","","","","","",<br>
> +       /*Y0-Y7*/   "","","","","","","","",<br>
> +       /*Z0-Z7*/   "POST_COMPLETE","POST_COMPLETE2","POST_COMPLETE3","POST_COMPLETE4","","","","",<br>
> +       /*AA0-AA7*/ "","","","","HAND_SW1","HAND_SW2","HAND_SW3","HAND_SW4",<br>
> +       /*AB0-AB7*/ "RESET_BUTTON","","","","","","","",<br>
> +               /*AC0-AC7*/ "","","","","","","","";<br>
> +};<br>
> +<br>
>  &i2c1 {<br>
>         //Host1 IPMB bus<br>
>         status = "okay";<br>
> @@ -207,11 +241,16 @@<br>
><br>
>  &i2c12 {<br>
>         status = "okay";<br>
> -       //MEZZ_FRU<br>
> -       eeprom@51 {<br>
> -               compatible = "atmel,24c64";<br>
> -               reg = <0x51>;<br>
> -               pagesize = <32>;<br>
> +};<br>
> +<br>
> +&i2c13 {<br>
> +       status = "okay";<br>
> +       // Debug Card<br>
> +       multi-master;<br>
> +       ipmb13@10 {<br>
> +               compatible = "ipmb-dev";<br>
> +               reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;<br>
> +               i2c-protocol;<br>
>         };<br>
>  };<br>
><br>
> --<br>
> 2.17.1<br>
><br>
</blockquote></div>