<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">Oops. Please ignore. Sent from incorrect workspace.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Nov 30, 2021 at 12:58 PM Ali El-Haj-Mahmoud <<a href="mailto:aaelhaj@google.com">aaelhaj@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">- Allow VUART and SuperIO to coexist.<br>
- Minor formatting.<br>
---<br>
 .../linux-aspeed/aspeed-bmc-tyan-s8036.dts    | 23 +++++++++++++++----<br>
 1 file changed, 18 insertions(+), 5 deletions(-)<br>
<br>
diff --git a/meta-tyan/meta-s8036/recipes-kernel/linux/linux-aspeed/aspeed-bmc-tyan-s8036.dts b/meta-tyan/meta-s8036/recipes-kernel/linux/linux-aspeed/aspeed-bmc-tyan-s8036.dts<br>
index 30b68ce89..7f650f6c8 100644<br>
--- a/meta-tyan/meta-s8036/recipes-kernel/linux/linux-aspeed/aspeed-bmc-tyan-s8036.dts<br>
+++ b/meta-tyan/meta-s8036/recipes-kernel/linux/linux-aspeed/aspeed-bmc-tyan-s8036.dts<br>
@@ -127,10 +127,23 @@<br>
        status = "okay";<br>
 };<br>
<br>
+&uart_routing {<br>
+       status = "okay";<br>
+};<br>
+<br>
 &vuart {<br>
        status = "okay";<br>
-       aspeed,lpc-io-reg = <0x3f8>;<br>
-       aspeed,lpc-interrupts = <4 IRQ_TYPE_LEVEL_HIGH>;<br>
+<br>
+       /* We enable the VUART here, but leave it in a state that does<br>
+        * not interfere with the SuperIO. The goal is to have both the<br>
+        * VUART and the SuperIO available and decide at runtime whether<br>
+        * the VUART should actually be used. For that reason, configure<br>
+        * an "invalid" IO address and an IRQ that is not used by the<br>
+        * BMC.<br>
+        */<br>
+<br>
+       aspeed,lpc-io-reg = <0xffff>;<br>
+       aspeed,lpc-interrupts = <15 IRQ_TYPE_LEVEL_HIGH>;<br>
 };<br>
<br>
 &lpc_ctrl {<br>
@@ -340,7 +353,7 @@<br>
<br>
 &kcs1 {<br>
        status = "okay";<br>
-   aspeed,lpc-io-reg = <0xca8>;<br>
+       aspeed,lpc-io-reg = <0xca8>;<br>
 };<br>
<br>
 &kcs3 {<br>
@@ -385,7 +398,7 @@<br>
        /*A6*/          "",<br>
        /*A7*/          "",<br>
        /*B0-B7*/       "","","","","","","","",<br>
-   /*C0-C7*/   "","","","","","","","",<br>
+       /*C0-C7*/       "","","","","","","","",<br>
        /*D0*/          "",<br>
        /*D1*/          "",<br>
        /*D2*/          "power-chassis-good", /* in: PWR_GOOD_LED -- Check if this is Z3?*/<br>
@@ -447,6 +460,6 @@<br>
        /*AA5*/         "",<br>
        /*AA6*/         "",<br>
        /*AA7*/         "BMC_ASSERT_BMC_READY",<br>
-   /*AB0*/     "BMC_SPD_SEL", <br>
+       /*AB0*/     "BMC_SPD_SEL", <br>
        /*AB1-AB7*/     "","","","","","","";<br>
 };<br>
-- <br>
2.34.0.rc2.393.gf8c9666880-goog<br>
<br>
</blockquote></div>