<br><br>On Friday, April 2, 2021, Zev Weiss <<a href="mailto:zev@bewilderbeest.net">zev@bewilderbeest.net</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This series generalizes the aspeed-vuart driver's device tree<br>
properties to cover all the attributes it currently exposes via sysfs.<br>
<br>
The aspeed,sirq-polarity-sense property was a bit of a design mistake<br>
in that it ties Aspeed VUART SIRQ polarity to SCU register bits that<br>
aren't really inherently related to it; the first patch in this series<br>
deprecates it (though we hope to eventually remove it).<br>
<br>
The rest of the series adds two new properties, aspeed,lpc-io-reg and<br>
aspeed,lpc-interrupts.  The latter allows describing the SIRQ polarity<br>
(along with the interrupt number) directly, providing a simpler<br>
replacement for aspeed,sirq-polarity-sense.<br>
<br>
<br></blockquote><div><br></div><div>Please, use better prefixes in the patches to avoid confusion, I.e. </div><div><br></div><div>“serial: 8250_aspeed_vuart: “</div><div><br></div><div>Instead of what you have now.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Changes since v3 [2]:<br>
 - renamed properties to match aspeed,ast2400-kcs-bmc<br>
<br>
Changes since v2 [0]:<br>
 - expanded to also handle sirq number and lpc address in addition to<br>
   sirq polarity<br>
 - added default settings if DT properties not specified<br>
 - refactored existing sysfs code slightly, adding range checks<br>
 - cleaned up 'make dt_binding_check' warnings<br>
<br>
Changes since v1 [1]:<br>
 - deprecate and retain aspeed,sirq-polarity-sense instead of removing it<br>
 - drop e3c246d4i dts addition from this series<br>
<br>
<br>
[0] <a href="https://lore.kernel.org/openbmc/20210401005702.28271-1-zev@bewilderbeest.net/" target="_blank">https://lore.kernel.org/<wbr>openbmc/20210401005702.28271-<wbr>1-zev@bewilderbeest.net/</a><br>
[1] <a href="https://lore.kernel.org/openbmc/20210330002338.335-1-zev@bewilderbeest.net/" target="_blank">https://lore.kernel.org/<wbr>openbmc/20210330002338.335-1-<wbr>zev@bewilderbeest.net/</a><br>
[2] <a href="https://lore.kernel.org/openbmc/20210402004716.15961-1-zev@bewilderbeest.net/" target="_blank">https://lore.kernel.org/<wbr>openbmc/20210402004716.15961-<wbr>1-zev@bewilderbeest.net/</a><br>
<br>
<br>
Zev Weiss (4):<br>
  dt-bindings: serial: 8250: deprecate aspeed,sirq-polarity-sense<br>
  drivers/tty/serial/8250: refactor sirq and lpc address setting code<br>
  drivers/tty/serial/8250: add aspeed,lpc-io-reg and<br>
    aspeed,lpc-interrupts DT properties<br>
  dt-bindings: serial: 8250: add aspeed,lpc-io-reg and<br>
    aspeed,lpc-interrupts<br>
<br>
 .../devicetree/bindings/<wbr>serial/8250.yaml      | 28 +++++-<br>
 drivers/tty/serial/8250/8250_<wbr>aspeed_vuart.c   | 95 +++++++++++++++----<br>
 2 files changed, 103 insertions(+), 20 deletions(-)<br>
<br>
-- <br>
2.31.1<br>
<br>
</blockquote><br><br>-- <br>With Best Regards,<br>Andy Shevchenko<br><br><br>