[v5 3/5] dt-bindings: mfd: Add aspeed pwm-tach binding

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Thu Jun 8 04:26:38 AEST 2023


On 07/06/2023 08:26, Billy Tsai wrote:
>> Missing description. But more important - why do you have such child
>> nodes? Your example does not have them. What's the point? Do you expect
>> different number of fans per one device (one compatible)?
> 
> In this patch series, I have included examples and descriptions to provide additional information.
> The child node is used to enable the channel of this tach controller.


Children are not for this. Look for cells examples (e.g. gpio-cells,
pwm-cells). It seems this is the same as Nuvoton NCT7362Y, so no. Don't
use reg for that purpose.

Best regards,
Krzysztof



More information about the Linux-aspeed mailing list