<div dir="ltr">Hi Florian,<div><br></div><div>This is very cool.. :-)<br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, May 31, 2013 at 7:42 AM, Florian Vaussard <span dir="ltr"><<a href="mailto:florian.vaussard@epfl.ch" target="_blank">florian.vaussard@epfl.ch</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Using constants for pinctrl allows a better readability, and removes<br>

redundancy with comments.<br>
<br>
Signed-off-by: Florian Vaussard <<a href="mailto:florian.vaussard@epfl.ch">florian.vaussard@epfl.ch</a>><br>
---<br>
 arch/arm/boot/dts/am335x-bone.dts  |   18 +++++++++---------<br>
 arch/arm/boot/dts/am335x-evm.dts   |   28 ++++++++++++++--------------<br>
 arch/arm/boot/dts/am335x-evmsk.dts |   26 +++++++++++++-------------<br>
 arch/arm/boot/dts/am33xx.dtsi      |    1 +<br>
 4 files changed, 37 insertions(+), 36 deletions(-)<br>
<br>
diff --git a/arch/arm/boot/dts/am335x-bone.dts b/arch/arm/boot/dts/am335x-bone.dts<br>
index 5bfb7dd..61d0793 100644<br>
--- a/arch/arm/boot/dts/am335x-bone.dts<br>
+++ b/arch/arm/boot/dts/am335x-bone.dts<br>
@@ -30,30 +30,30 @@<br>
<br>
                user_leds_s0: user_leds_s0 {<br>
                        pinctrl-single,pins = <<br>
-                               0x54 0x7        /* gpmc_a5.gpio1_21, OUTPUT | MODE7 */<br>
-                               0x58 0x17       /* gpmc_a6.gpio1_22, OUTPUT_PULLUP | MODE7 */<br>
-                               0x5c 0x7        /* gpmc_a7.gpio1_23, OUTPUT | MODE7 */<br>
-                               0x60 0x17       /* gpmc_a8.gpio1_24, OUTPUT_PULLUP | MODE7 */<br>
+                               0x54 (PIN_OUTPUT | MUX_MODE7)           /* gpmc_a5.gpio1_21 */<br>
+                               0x58 (PIN_OUTPUT | PULL_UP | MUX_MODE7) /* gpmc_a6.gpio1_22 */<br>
+                               0x5c (PIN_OUTPUT | MUX_MODE7)           /* gpmc_a7.gpio1_23 */<br>
+                               0x60 (PIN_OUTPUT | PULL_UP | MUX_MODE7) /* gpmc_a8.gpio1_24 */<br><br></blockquote><div><br></div><div style>Does it make sense to also replace the pinmux offets with constants?</div><div style>
Removal of the comment would mean looking at the DTS one still has to go back to the TRM to figure out what is the name for a particular offset.</div><div style><br></div><div style>Thanks,</div><div style>Joel</div></div>
</div></div></div>