<div dir="ltr">Hi Olof,<br><div class="gmail_extra"><br><br><div class="gmail_quote">On 10 May 2013 11:51, Vikas Sajjan <span dir="ltr"><<a href="mailto:vikas.sajjan@linaro.org" target="_blank">vikas.sajjan@linaro.org</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi Olof,<br><div class="gmail_extra"><div><div class="h5"><br><br><div class="gmail_quote">

On 10 May 2013 11:08, Olof Johansson <span dir="ltr"><<a href="mailto:olof@lixom.net" target="_blank">olof@lixom.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div>On Thu, May 9, 2013 at 7:55 PM, Vikas Sajjan <<a href="mailto:vikas.sajjan@linaro.org" target="_blank">vikas.sajjan@linaro.org</a>> wrote:<br>



> Hi Tomasz,<br>
><br>
><br>
> On 10 May 2013 05:35, Tomasz Figa <<a href="mailto:tomasz.figa@gmail.com" target="_blank">tomasz.figa@gmail.com</a>> wrote:<br>
>><br>
>> Hi Vikas,<br>
>><br>
>> On Wednesday 08 of May 2013 11:31:34 Vikas Sajjan wrote:<br>
>> > Adds display timing node for a DP panel to Arndale Board DTS file<br>
>> ><br>
>> > Signed-off-by: Vikas Sajjan <<a href="mailto:vikas.sajjan@linaro.org" target="_blank">vikas.sajjan@linaro.org</a>><br>
>> > ---<br>
>> >  arch/arm/boot/dts/exynos5250-arndale.dts |   16 ++++++++++++++++<br>
>> >  1 file changed, 16 insertions(+)<br>
>> ><br>
>> > diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts<br>
>> > b/arch/arm/boot/dts/exynos5250-arndale.dts index f68b820..c831a5c<br>
>> > 100644<br>
>> > --- a/arch/arm/boot/dts/exynos5250-arndale.dts<br>
>> > +++ b/arch/arm/boot/dts/exynos5250-arndale.dts<br>
>> > @@ -459,4 +459,20 @@<br>
>> >               samsung,lane-count = <4>;<br>
>> >       };<br>
>> ><br>
>> > +     display-timings {<br>
>> > +             native-mode = <&timing0>;<br>
>> > +             timing0: timing@0 {<br>
>> > +                     /* 2560x1600 DP panel */<br>
>> > +                     clock-frequency = <50000>;<br>
>> > +                     hactive = <2560>;<br>
>> > +                     vactive = <1600>;<br>
>> > +                     hfront-porch = <48>;<br>
>> > +                     hback-porch = <80>;<br>
>> > +                     hsync-len = <32>;<br>
>> > +                     vback-porch = <16>;<br>
>> > +                     vfront-porch = <8>;<br>
>> > +                     vsync-len = <6>;<br>
>> > +             };<br>
>> > +     };<br>
>><br>
>> What display are those timings used for? Shouldn't they be placed inside<br>
>> node of that display?<br>
>><br>
><br>
> This timing information will be used parsed by the FIMD probe with the help<br>
> of "Video Helper function"  as done in this link<br>
><br>
> <a href="https://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/commit/?h=exynos-drm-next&id=7f4596f4aebcc9fcf2d50d3fe398508d710c4dd0" target="_blank">https://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/commit/?h=exynos-drm-next&id=7f4596f4aebcc9fcf2d50d3fe398508d710c4dd0</a><br>



<br>
</div></div>That function passes in a device node pointer to the FIMD device node,<br>
and only looks for a display-timings node under there. Tomasz is<br>
right, as far as I can tell.<br>
<br>
Placing display timings at the root of the device tree seems completely wrong.<br>
<div><br></div></blockquote></div></div></div></div></div></blockquote><div>        I referred this " Documentation/devicetree/bindings/video/display-timing.txt" for example<br><br></div><div>            here it dosen't mention about whether display timings node can be placed at the root of the device tree or NOT.<br>

</div><div> Not sure how we should be placing the node then.<br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">

<div class="gmail_extra"><div><div class="h5"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div></div></blockquote><div>

 </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div>
> Please refer to this patch which is used for exynos4412-origen and<br>
> exynos5250-smdk5250 respectively in similar way<br>
><br>
> <a href="https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/commit/?h=for-next&id=0207775d6ff7e6a6eddb9931f9328f0f0173a338" target="_blank">https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/commit/?h=for-next&id=0207775d6ff7e6a6eddb9931f9328f0f0173a338</a><br>



><br>
> <a href="https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/commit/?h=for-next&id=06c460b73f75894cabfb1f5277f27cddbc92745c" target="_blank">https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/commit/?h=for-next&id=06c460b73f75894cabfb1f5277f27cddbc92745c</a><br>



<br>
</div>That needs to be fixed up as well, thanks for pointing it out.<br>
<span><font color="#888888"><br>
<br>
-Olof<br>
</font></span></blockquote></div><br><br clear="all"><br></div></div><div class="im">-- <br>Thanks and Regards<div> Vikas Sajjan</div>
</div></div></div>
</blockquote></div><br><br clear="all"><br>-- <br>Thanks and Regards<div> Vikas Sajjan</div>
</div></div>