<div dir="ltr">Thank you.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On 8 April 2013 12:53, Kukjin Kim <span dir="ltr"><<a href="mailto:kgene.kim@samsung.com" target="_blank">kgene.kim@samsung.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">Vikas Sajjan wrote:<br>
><br>
> This patch series adds support for DRM FIMD DT for Exynos4 DT Machines,<br>
> specifically for Exynos4412 SoC.<br>
><br>
> changes since v10:<br>
> - addressed comments from Sylwester Nawrocki<br>
> <<a href="mailto:sylvester.nawrocki@gmail.com">sylvester.nawrocki@gmail.com</a>><br>
><br>
> changes since v9:<br>
> - dropped the patch "ARM: dts: Add lcd pinctrl node entries for<br>
> EXYNOS4412 SoC"<br>
> as the gpios in the newly added nodes "lcd_en" and "lcd_sync" in<br>
> this patch<br>
> were already PULLed high by existing "lcd_clk" node.<br>
> - addressed comments from Sylwester Nawrocki<br>
> <<a href="mailto:sylvester.nawrocki@gmail.com">sylvester.nawrocki@gmail.com</a>><br>
> and Thomas Abraham <<a href="mailto:thomas.abraham@linaro.org">thomas.abraham@linaro.org</a>><br>
><br>
> changes since v8:<br>
> - addressed comments to add missing documentation for clock and<br>
> clock-names<br>
> properties as pointed out by Sachin Kamat <<a href="mailto:sachin.kamat@linaro.org">sachin.kamat@linaro.org</a>><br>
><br>
> changes since v7:<br>
> - rebased to kgene's "for-next"<br>
> - Migrated to Common Clock Framework<br>
> - removed the patch "ARM: dts: Add FIMD AUXDATA node entry for<br>
> exynos4 DT",<br>
> as migration to Common Clock Framework will NOT need this.<br>
> - addressed the comments raised by Sachin Kamat<br>
> <<a href="mailto:sachin.kamat@linaro.org">sachin.kamat@linaro.org</a>><br>
><br>
> changes since v6:<br>
> - addressed comments and added interrupt-names = "fifo", "vsync",<br>
> "lcd_sys"<br>
> in exynos4.dtsi and re-ordered the interrupt numbering to match the<br>
> order in<br>
> interrupt combiner IP as suggested by Sylwester Nawrocki<br>
> <<a href="mailto:sylvester.nawrocki@gmail.com">sylvester.nawrocki@gmail.com</a>>.<br>
><br>
> changes since v5:<br>
> - renamed the fimd binding documentation file name as "samsung-<br>
> fimd.txt",<br>
> since it not only talks about exynos display controller but also<br>
> about<br>
> previous samsung display controllers.<br>
> - rephrased an abmigious statement about the interrupt combiner in<br>
> the<br>
> fimd binding documentation as pointed out by<br>
> Sachin Kamat <<a href="mailto:sachin.kamat@linaro.org">sachin.kamat@linaro.org</a>><br>
><br>
> changes since v4:<br>
> - moved the fimd binding documentation to<br>
> Documentation/devicetree/bindings/video/<br>
> as suggested by Sylwester Nawrocki <<a href="mailto:sylvester.nawrocki@gmail.com">sylvester.nawrocki@gmail.com</a>><br>
><br>
> - added more fimd compatiblity strings in fimd documentation as<br>
> discussed at <a href="https://patchwork.kernel.org/patch/2144861/" target="_blank">https://patchwork.kernel.org/patch/2144861/</a> with<br>
> Sylwester Nawrocki <<a href="mailto:sylvester.nawrocki@gmail.com">sylvester.nawrocki@gmail.com</a>> and<br>
> Tomasz Figa <<a href="mailto:tomasz.figa@gmail.com">tomasz.figa@gmail.com</a>><br>
><br>
> - modified compatible string for exynos4 fimd as "exynos4210-fimd"<br>
> exynos5 fimd as "exynos5250-fimd" to stick to the rule that<br>
> compatible<br>
> value should be named after first specific SoC model in which this<br>
> particular IP version was included as discussed at<br>
> <a href="https://patchwork.kernel.org/patch/2144861/" target="_blank">https://patchwork.kernel.org/patch/2144861/</a><br>
><br>
> - documented more about the interrupt combiner and their order as<br>
> suggested by Sylwester Nawrocki <<a href="mailto:sylvester.nawrocki@gmail.com">sylvester.nawrocki@gmail.com</a>><br>
><br>
> changes since v3:<br>
> - rebased on<br>
> <a href="http://git.kernel.org/?p=linux/kernel/git/kgene/linux-" target="_blank">http://git.kernel.org/?p=linux/kernel/git/kgene/linux-</a><br>
> samsung.git;a=shortlog;h=refs/heads/for-next-next<br>
><br>
> changes since v2:<br>
> - added alias to 'fimd@11c00000' node<br>
> (reported by: Rahul Sharma <<a href="mailto:r.sh.open@gmail.com">r.sh.open@gmail.com</a>>)<br>
> - removed 'lcd0_data' node as there was already a similar node<br>
> lcd_data24<br>
> (reported by: Jingoo Han <<a href="mailto:jg1.han@samsung.com">jg1.han@samsung.com</a>><br>
> - replaced spaces with tabs in display-timing node<br>
><br>
> changes since v1:<br>
> - added new patch to add FIMD DT binding Documentation<br>
> - removed patch enabling SAMSUNG_DEV_BACKLIGHT and SAMSUNG_DEV_PMW<br>
> for mach-exynos4 DT<br>
> - added 'status' property to fimd DT node<br>
><br>
> Is based on branch kgene's "for-next"<br>
> <a href="https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-" target="_blank">https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-</a><br>
> samsung.git/log/?h=for-next<br>
><br>
> Vikas Sajjan (3):<br>
> ARM: dts: Add FIMD node to exynos4<br>
> ARM: dts: Add FIMD node and display timing node to<br>
> exynos4412-origen.dts<br>
> ARM: dts: Add FIMD DT binding Documentation<br>
><br>
> .../devicetree/bindings/video/samsung-fimd.txt | 65<br>
> ++++++++++++++++++++<br>
> arch/arm/boot/dts/exynos4.dtsi | 12 ++++<br>
> arch/arm/boot/dts/exynos4412-origen.dts | 21 +++++++<br>
> 3 files changed, 98 insertions(+)<br>
> create mode 100644 Documentation/devicetree/bindings/video/samsung-<br>
> fimd.txt<br>
><br>
> --<br>
> 1.7.9.5<br>
<br>
</div></div>Looks good to me, applied.<br>
<br>
Thanks.<br>
<span class="HOEnZb"><font color="#888888"><br>
- Kukjin<br>
<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br>Thanks and Regards<div> Vikas Sajjan</div>
</div>