<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from rtf -->
<style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<font face="Calibri" size="2"><span style="font-size:11pt;">
<div>Hi Peter,</div>
<div> </div>
<div>Just trying to understand.</div>
<div> </div>
<div>In omap-twl4030.c file probe function :-</div>
<div> </div>
<div> dai_node = of_parse_phandle(node, "ti,mcbsp", 0);</div>
<div> if (!dai_node) {</div>
<div> dev_err(&pdev->dev, "McBSP node is not provided\n");</div>
<div> return -EINVAL;</div>
<div> }</div>
<div> </div>
<div>Here “of_parse_phandle()” is used to get “of_device” node pointer.</div>
<div>of_parse_phandle() suggest to use of_node_put() on it when done.</div>
<div> </div>
<div>It looks when code request for an “of_device” node, kernel maintains “refcount” for this.</div>
<div>It check “refcount” before giving pointer of of_device node and WARN_ON()</div>
<div>in case of refcount > 0 and increase it on success. </div>
<div> </div>
<div>Should this code need to use of_node_put() on the requested “of_device” when done</div>
<div>so that this can be get again ?</div>
<div> </div>
<div>I am taking reference of Linux-next kernel.</div>
<div> </div>
<div>I'm sorry if this question is very vague or missing something.</div>
<div> </div>
<div>Thanks,</div>
<div>Anil</div>
<div> </div>
<div> </div>
<div> </div>
<div> </div>
<div> </div>
<div> </div>
</span></font>
</body>
</html>