<br><br><div class="gmail_quote">2012/12/10 Stéphane Marchesin <span dir="ltr"><<a href="mailto:stephane.marchesin@gmail.com" target="_blank">stephane.marchesin@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On Sun, Dec 9, 2012 at 10:26 PM, Inki Dae <<a href="mailto:inki.dae@samsung.com">inki.dae@samsung.com</a>> wrote:<br>
><br>
><br>
> 2012/12/6 R. Chandrasekar <<a href="mailto:rcsekar@samsung.com">rcsekar@samsung.com</a>><br>
><br>
>> From: "R. Chandrasekar" <<a href="mailto:rcsekar@samsung.com">rcsekar@samsung.com</a>><br>
>><br>
>> this patch set adds the driver support for the dithering functionality of<br>
>> the<br>
>> mobile image enhancement (mie) module.<br>
>><br>
>> device tree support is added for mie.<br>
>><br>
>> fimd adds the mie module as plugin and calls the dithering function.<br>
>> dithere is<br>
>> required when the panels bpp is less then fimd output.<br>
>><br>
>> though mie mie has other functionalities, current system uses only<br>
>> dithereing.<br>
>><br>
><br>
> Please, move mie module into drivers/video/exynos. The mie is a interface<br>
> between fimd and lcd panel(or mipi-dsi, eDP) to enhance image to be<br>
> displayed. And it seems like that this doesn't need drm framework-relevant<br>
> interfaces, such as gem.<br>
<br>
</div>Well, if you want to support it from the DRM, it should live in<br>
drivers/gpu/drm, and I don't think you should add another platform<br>
driver in the first place. The profusion of platform drivers in exynos<br>
makes it really difficult to support suspend/resume and initialization<br>
properly as many devices which operate separately need to sync through<br>
global variables.<br>
<span class="HOEnZb"><font color="#888888"><br></font></span></blockquote><div><br>MIE could be used by linux framebuffer-based specific driver(s3c-fb) also. If linux framebuffer-based driver want to use this mie module, should the mie module be placed in drivers/video coping it? I think it's not good so it's better way to use this mie module commonly without duplicated codes. And mipi-dsi and eDP drivers also have their own platform device/driver and are being used by exynos drm driver or s3c-fb driver. Of course, for some IPs such as mie between display controller and lcd panel, It seems like that there should be proper framework or interfaces in drivers/video/exynos or somewhere so that other frameworks can use it commonly. And drm and linux framebuffer drivers should call the interfaces.<br>
<br>Thanks,<br>Inki Dae<br><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="HOEnZb"><font color="#888888">
Stéphane<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
><br>
> And also, please refer to the below link, Common Display Framework, for more<br>
> generic way.<br>
><br>
> <a href="http://lists.freedesktop.org/archives/dri-devel/2012-November/030888.html" target="_blank">http://lists.freedesktop.org/archives/dri-devel/2012-November/030888.html</a><br>
><br>
> Thanks,<br>
> Inki Dae<br>
><br>
>><br>
>> R. Chandrasekar (3):<br>
>> DTS: exynos: add device tree support for exynos mie<br>
>> drm: fimd: add mie plugin support for dithering<br>
>> drm: mie: add mie driver for exynos<br>
>><br>
>> arch/arm/boot/dts/exynos5250.dtsi | 7 +-<br>
>> drivers/gpu/drm/exynos/Kconfig | 7 +<br>
>> drivers/gpu/drm/exynos/Makefile | 1 +<br>
>> drivers/gpu/drm/exynos/exynos_drm_fimd.c | 58 +++++-<br>
>> drivers/gpu/drm/exynos/exynos_drm_fimd_common.h | 20 ++<br>
>> drivers/gpu/drm/exynos/exynos_drm_mie.c | 250<br>
>> +++++++++++++++++++++++<br>
>> drivers/gpu/drm/exynos/exynos_drm_mie.h | 50 +++++<br>
>> drivers/gpu/drm/exynos/exynos_regs-mie.h | 75 +++++++<br>
>> 8 files changed, 465 insertions(+), 3 deletions(-)<br>
>> create mode 100644 drivers/gpu/drm/exynos/exynos_drm_fimd_common.h<br>
>> create mode 100644 drivers/gpu/drm/exynos/exynos_drm_mie.c<br>
>> create mode 100644 drivers/gpu/drm/exynos/exynos_drm_mie.h<br>
>> create mode 100644 drivers/gpu/drm/exynos/exynos_regs-mie.h<br>
>><br>
>> --<br>
>> 1.7.9.5<br>
>><br>
>> _______________________________________________<br>
>> dri-devel mailing list<br>
>> <a href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a><br>
>> <a href="http://lists.freedesktop.org/mailman/listinfo/dri-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br>
><br>
><br>
><br>
> _______________________________________________<br>
> dri-devel mailing list<br>
> <a href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a><br>
> <a href="http://lists.freedesktop.org/mailman/listinfo/dri-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br>
><br>
_______________________________________________<br>
dri-devel mailing list<br>
<a href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/dri-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br>
</div></div></blockquote></div><br>